Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 27446002: Move permission warning message handling from PermissionSet to PermissionMessageProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/permissions_data.h" 5 #include "chrome/common/extensions/permissions/permissions_data.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/common/extensions/extension.h" 14 #include "chrome/common/extensions/extension.h"
15 #include "chrome/common/extensions/permissions/chrome_scheme_hosts.h" 15 #include "chrome/common/extensions/permissions/chrome_scheme_hosts.h"
16 #include "chrome/common/extensions/permissions/permission_set.h" 16 #include "chrome/common/extensions/permissions/permission_set.h"
17 #include "content/public/common/url_constants.h" 17 #include "content/public/common/url_constants.h"
18 #include "extensions/common/constants.h" 18 #include "extensions/common/constants.h"
19 #include "extensions/common/error_utils.h" 19 #include "extensions/common/error_utils.h"
20 #include "extensions/common/features/feature.h" 20 #include "extensions/common/features/feature.h"
21 #include "extensions/common/features/feature_provider.h" 21 #include "extensions/common/features/feature_provider.h"
22 #include "extensions/common/manifest.h" 22 #include "extensions/common/manifest.h"
23 #include "extensions/common/manifest_constants.h" 23 #include "extensions/common/manifest_constants.h"
24 #include "extensions/common/manifest_constants.h" 24 #include "extensions/common/manifest_constants.h"
25 #include "extensions/common/permissions/api_permission_set.h" 25 #include "extensions/common/permissions/api_permission_set.h"
26 #include "extensions/common/permissions/permission_message_provider.h"
26 #include "extensions/common/permissions/permissions_info.h" 27 #include "extensions/common/permissions/permissions_info.h"
27 #include "extensions/common/switches.h" 28 #include "extensions/common/switches.h"
28 #include "extensions/common/url_pattern_set.h" 29 #include "extensions/common/url_pattern_set.h"
29 #include "extensions/common/user_script.h" 30 #include "extensions/common/user_script.h"
30 #include "url/gurl.h" 31 #include "url/gurl.h"
31 32
32 namespace extensions { 33 namespace extensions {
33 34
34 namespace keys = manifest_keys; 35 namespace keys = manifest_keys;
35 namespace errors = manifest_errors; 36 namespace errors = manifest_errors;
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 return GetActivePermissions(extension)->HasEffectiveAccessToAllHosts(); 416 return GetActivePermissions(extension)->HasEffectiveAccessToAllHosts();
416 } 417 }
417 418
418 // static 419 // static
419 PermissionMessages PermissionsData::GetPermissionMessages( 420 PermissionMessages PermissionsData::GetPermissionMessages(
420 const Extension* extension) { 421 const Extension* extension) {
421 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_); 422 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
422 if (ShouldSkipPermissionWarnings(extension)) { 423 if (ShouldSkipPermissionWarnings(extension)) {
423 return PermissionMessages(); 424 return PermissionMessages();
424 } else { 425 } else {
425 return GetActivePermissions(extension)->GetPermissionMessages( 426 return PermissionMessageProvider::Get()->GetPermissionMessages(
426 extension->GetType()); 427 GetActivePermissions(extension), extension->GetType());
427 } 428 }
428 } 429 }
429 430
430 // static 431 // static
431 std::vector<string16> PermissionsData::GetPermissionMessageStrings( 432 std::vector<string16> PermissionsData::GetPermissionMessageStrings(
432 const Extension* extension) { 433 const Extension* extension) {
433 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_); 434 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
434 if (ShouldSkipPermissionWarnings(extension)) { 435 if (ShouldSkipPermissionWarnings(extension)) {
435 return std::vector<string16>(); 436 return std::vector<string16>();
436 } else { 437 } else {
437 return GetActivePermissions(extension)->GetWarningMessages( 438 return PermissionMessageProvider::Get()->GetWarningMessages(
438 extension->GetType()); 439 GetActivePermissions(extension), extension->GetType());
439 } 440 }
440 } 441 }
441 442
442 // static 443 // static
443 std::vector<string16> PermissionsData::GetPermissionMessageDetailsStrings( 444 std::vector<string16> PermissionsData::GetPermissionMessageDetailsStrings(
444 const Extension* extension) { 445 const Extension* extension) {
445 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_); 446 base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
446 if (ShouldSkipPermissionWarnings(extension)) { 447 if (ShouldSkipPermissionWarnings(extension)) {
447 return std::vector<string16>(); 448 return std::vector<string16>();
448 } else { 449 } else {
449 return GetActivePermissions(extension)->GetWarningMessagesDetails( 450 return PermissionMessageProvider::Get()->GetWarningMessagesDetails(
450 extension->GetType()); 451 GetActivePermissions(extension), extension->GetType());
451 } 452 }
452 } 453 }
453 454
454 // static 455 // static
455 bool PermissionsData::CanExecuteScriptOnPage(const Extension* extension, 456 bool PermissionsData::CanExecuteScriptOnPage(const Extension* extension,
456 const GURL& document_url, 457 const GURL& document_url,
457 const GURL& top_frame_url, 458 const GURL& top_frame_url,
458 int tab_id, 459 int tab_id,
459 const UserScript* script, 460 const UserScript* script,
460 int process_id, 461 int process_id,
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 optional_permission_set_ = new PermissionSet( 623 optional_permission_set_ = new PermissionSet(
623 initial_optional_permissions_->api_permissions, 624 initial_optional_permissions_->api_permissions,
624 initial_optional_permissions_->host_permissions, 625 initial_optional_permissions_->host_permissions,
625 URLPatternSet()); 626 URLPatternSet());
626 627
627 initial_required_permissions_.reset(); 628 initial_required_permissions_.reset();
628 initial_optional_permissions_.reset(); 629 initial_optional_permissions_.reset();
629 } 630 }
630 631
631 } // namespace extensions 632 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | extensions/common/extensions_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698