Move permission warning message handling from PermissionSet to PermissionMessageProvider.

chrome/common/extensions/permissions/base_permission_message_provider.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_BASE_PERMISSION_MESSAGE_PROVIDER_H_
+#define CHROME_COMMON_EXTENSIONS_PERMISSIONS_BASE_PERMISSION_MESSAGE_PROVIDER_H_
+
+#include <set>
+
+#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
+#include "base/strings/string16.h"
+#include "extensions/common/permissions/permission_message_provider.h"
+
+namespace extensions {
+
+class BasePermissionMessageProvider : public PermissionMessageProvider {

[Matt Perry, 2013/10/17 21:47:30]

Well, now it's not a base class anymore :)

How about ChromePermissionMessageProvider, in the spirit of the other chrome
delegate implementations? (sorry to be a pain)

[Yoyo Zhou, 2013/10/18 19:08:00]

Sure.

+ public:
+  BasePermissionMessageProvider();
+  virtual ~BasePermissionMessageProvider();
+
+  // PermissionMessageProvider implementation.
+  virtual PermissionMessages GetPermissionMessages(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const OVERRIDE;
+  virtual std::vector<string16> GetWarningMessages(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const OVERRIDE;
+  virtual std::vector<string16> GetWarningMessagesDetails(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const OVERRIDE;
+  virtual bool IsPrivilegeIncrease(
+      const PermissionSet* old_permissions,
+      const PermissionSet* new_permissions,
+      Manifest::Type extension_type) const OVERRIDE;
+
+ private:
+  // Gets the permission messages for the API permissions.
+  std::set<PermissionMessage> GetAPIPermissionMessages(
+      const PermissionSet* permissions) const;
+
+  // Gets the permission messages for the host permissions.
+  std::set<PermissionMessage> GetHostPermissionMessages(
+      const PermissionSet* permissions,
+      Manifest::Type extension_type) const;
+
+  // Returns true if |new_permissions| has an elevated API privilege level
+  // compared to |old_permissions|.
+  bool IsAPIPrivilegeIncrease(
+      const PermissionSet* old_permissions,
+      const PermissionSet* new_permissions) const;
+
+  // Returns true if |new_permissions| has more host permissions compared to
+  // |old_permissions|.
+  bool IsHostPrivilegeIncrease(
+      const PermissionSet* old_permissions,
+      const PermissionSet* new_permissions,
+      Manifest::Type extension_type) const;
+
+  DISALLOW_COPY_AND_ASSIGN(BasePermissionMessageProvider);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_COMMON_EXTENSIONS_PERMISSIONS_BASE_PERMISSION_MESSAGE_PROVIDER_H_