third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 2744593002: [css-grid] Protect against negative values in applyStretchAlignmentToChildIfNeeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2744593002: [css-grid] Protect against negative values in applyStretchAlignmentToChildIfNeeded() (Closed)

Patch Set: Simplify test to make issue even clearer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index 554dd56f02e6a7f27964a87cb991eb8c92460a91..dea30d9373489093bfb81f862b24634064ba5966 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -1473,7 +1473,8 @@ void LayoutGrid::applyStretchAlignmentToChildIfNeeded(LayoutBox& child) {

LayoutUnit desiredLogicalHeight = child.constrainLogicalHeightByMinMax(

stretchedLogicalHeight, LayoutUnit(-1));

child.setOverrideLogicalContentHeight(

- desiredLogicalHeight - child.borderAndPaddingLogicalHeight());

+ (desiredLogicalHeight - child.borderAndPaddingLogicalHeight())

+ .clampNegativeToZero());

if (desiredLogicalHeight != child.logicalHeight()) {

// TODO (lajava): Can avoid laying out here in some cases. See

// https://webkit.org/b/87905.