Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 274453011: Revert of Collect data reduction proxy UMA on all platforms (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Collect data reduction proxy UMA on all platforms (https://codereview.chromium.org/266033002/) Reason for revert: Causes a sizes regression, starting in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64712 +# data_reduction_proxy_settings.cc data_reduction_proxy::DataReductionProxySettings::key_ +# data_reduction_proxy_settings.cc __cxa_atexit@plt [registers a dtor to run at exit] +# data_reduction_proxy_settings.cc __init_array_end+0x3868 +# data_reduction_proxy_settings.cc __init_array_end+0x3b88 +# data_reduction_proxy_settings.cc __init_array_end+0x530 Original issue's description: > Collect data reduction proxy UMA on all platforms > > UMA for the data reduction proxy was gated behind preprocessor > directives that resticted the logic to Android and iOS. This > change opens UMA calculations and collection up to all platforms. > > BUG=369619 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026 TBR=mef@chromium.org,marq@chromium.org,bengr@chromium.org NOTREECHECKS=true NOTRY=true BUG=369619 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 9 chunks +15 lines, -10 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics_unittest.cc View 6 chunks +8 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Created Revert of Collect data reduction proxy UMA on all platforms
6 years, 7 months ago (2014-05-08 05:57:19 UTC) #1
tapted
The CQ bit was unchecked by tapted@chromium.org
6 years, 7 months ago (2014-05-08 05:57:52 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-05-08 06:00:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/274453011/1
6 years, 7 months ago (2014-05-08 06:02:39 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 06:05:36 UTC) #5
Message was sent while issue was closed.
Change committed as 269041

Powered by Google App Engine
This is Rietveld 408576698