Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.h

Issue 2744483002: Move asserts for tracking global object detachment to WindowProxy. (Closed)
Patch Set: GlobalProxy -> GlobalObject Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.h b/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
index cbe01ec0bc20a6cf45f997a3e7d32e969c01b0f5..9b60146f7a3e9a6585557d06abfb140fed4dd672 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
@@ -156,9 +156,6 @@ class CORE_EXPORT ScriptState : public RefCounted<ScriptState> {
}
void detachGlobalObject();
void clearContext() { return m_context.clear(); }
-#if DCHECK_IS_ON()
- bool isGlobalObjectDetached() const { return m_globalObjectDetached; }
-#endif
V8PerContextData* perContextData() const { return m_perContextData.get(); }
void disposePerContextData();
@@ -184,10 +181,6 @@ class CORE_EXPORT ScriptState : public RefCounted<ScriptState> {
// disposePerContextData() once you no longer need V8PerContextData.
// Otherwise, the v8::Context will leak.
std::unique_ptr<V8PerContextData> m_perContextData;
-
-#if DCHECK_IS_ON()
- bool m_globalObjectDetached = false;
-#endif
};
// ScriptStateProtectingContext keeps the context associated with the

Powered by Google App Engine
This is Rietveld 408576698