third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp - Issue 2744483002: Move asserts for tracking global object detachment to WindowProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2744483002: Move asserts for tracking global object detachment to WindowProxy. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

index 4dcdb8177ec21b16fdfdf722629bba98c27c976b..3f91993c35d2f2529e2ddf0b1b1d6f42b3fc35e0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

@@ -51,9 +51,6 @@ ScriptState::~ScriptState() {

void ScriptState::detachGlobalObject() {

ASSERT(!m_context.isEmpty());

context()->DetachGlobal();

-#if DCHECK_IS_ON()

- m_globalObjectDetached = true;

-#endif

}

void ScriptState::disposePerContextData() {