Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: ui/views/controls/button/vector_icon_button.h

Issue 2744463002: Add VectorIconButton functionality to ImageButton. (Closed)
Patch Set: wip: address high-level comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/vector_icon_button.h
diff --git a/ui/views/controls/button/vector_icon_button.h b/ui/views/controls/button/vector_icon_button.h
index 66f1b93864ec3820893f78adebaa62bc5a486472..c7185b4d7648f525a06b366547e6f7e7050a56b7 100644
--- a/ui/views/controls/button/vector_icon_button.h
+++ b/ui/views/controls/button/vector_icon_button.h
@@ -17,15 +17,13 @@ namespace views {
class VectorIconButtonDelegate;
-// A button that has an image and no text, with the image defined by a vector
-// icon identifier.
+// A button that has a image from a vector icon and no text.
class VIEWS_EXPORT VectorIconButton : public views::ImageButton {
public:
explicit VectorIconButton(VectorIconButtonDelegate* delegate);
~VectorIconButton() override;
- // Sets the icon to display and provides a callback which should return the
- // text color from which to derive this icon's color.
+ // Sets the icon to display.
void SetIcon(const gfx::VectorIcon& icon);
// views::ImageButton:
@@ -33,9 +31,6 @@ class VIEWS_EXPORT VectorIconButton : public views::ImageButton {
void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
private:
- // Performs the work common to both SetIcon() variants.
- void OnSetIcon();
-
// Called when something may have affected the button's images or colors.
void UpdateImagesAndColors();

Powered by Google App Engine
This is Rietveld 408576698