Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2681)

Unified Diff: chrome/browser/ui/views/find_bar_view.h

Issue 2744463002: Add VectorIconButton functionality to ImageButton. (Closed)
Patch Set: wip: address high-level comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/find_bar_view.h
diff --git a/chrome/browser/ui/views/find_bar_view.h b/chrome/browser/ui/views/find_bar_view.h
index 212f47416903c2fa9900e457e0c673fd03edf1b9..2fc26cc34e023e66a5ab3da88b5e1959b2764862 100644
--- a/chrome/browser/ui/views/find_bar_view.h
+++ b/chrome/browser/ui/views/find_bar_view.h
@@ -5,13 +5,12 @@
#ifndef CHROME_BROWSER_UI_VIEWS_FIND_BAR_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_FIND_BAR_VIEW_H_
-#include <memory>
-
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/strings/string16.h"
#include "chrome/browser/ui/views/dropdown_bar_host_delegate.h"
-#include "ui/views/controls/button/vector_icon_button_delegate.h"
+#include "ui/views/controls/button/button.h"
+#include "ui/views/controls/button/vector_icon_image_updater.h"
#include "ui/views/controls/textfield/textfield_controller.h"
#include "ui/views/view.h"
#include "ui/views/view_targeter_delegate.h"
@@ -28,7 +27,7 @@ class Label;
class Painter;
class Separator;
class Textfield;
-class VectorIconButton;
+class ImageButton;
}
////////////////////////////////////////////////////////////////////////////////
@@ -40,7 +39,7 @@ class VectorIconButton;
////////////////////////////////////////////////////////////////////////////////
class FindBarView : public views::View,
public DropdownBarHostDelegate,
- public views::VectorIconButtonDelegate,
+ public views::ButtonListener,
public views::TextfieldController,
public views::ViewTargeterDelegate {
public:
@@ -74,9 +73,8 @@ class FindBarView : public views::View,
// DropdownBarHostDelegate:
void SetFocusAndSelection(bool select_all) override;
- // views::VectorIconButtonDelegate:
+ // views::ButtonListener:
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
- SkColor GetVectorIconBaseColor() const override;
// views::TextfieldController:
bool HandleKeyEvent(views::Textfield* sender,
@@ -88,6 +86,21 @@ class FindBarView : public views::View,
views::View* TargetForRect(View* root, const gfx::Rect& rect) override;
private:
+ class FindBarViewButtonImageUpdater : public views::VectorIconImageUpdater {
+ public:
+ FindBarViewButtonImageUpdater(const gfx::VectorIcon& icon,
+ FindBarView* parent);
+
+ protected:
+ // views::VectorIconImageUpdater:
+ SkColor GetVectorIconColor() const override;
+
+ private:
+ const FindBarView* parent_;
+ };
+
+ views::ImageButton* CreateButton(const gfx::VectorIcon& icon);
+
// Starts finding |search_text|. If the text is empty, stops finding.
void Find(const base::string16& search_text);
@@ -115,9 +128,9 @@ class FindBarView : public views::View,
views::Label* match_count_text_;
views::View* focus_forwarder_view_;
views::Separator* separator_;
- views::VectorIconButton* find_previous_button_;
- views::VectorIconButton* find_next_button_;
- views::VectorIconButton* close_button_;
+ views::ImageButton* find_previous_button_;
+ views::ImageButton* find_next_button_;
+ views::ImageButton* close_button_;
// The preferred height of the find bar.
int preferred_height_;

Powered by Google App Engine
This is Rietveld 408576698