Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering().

Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering(). (https://codereview.chromium.org/277123002/)

Reason for revert:
This seems to have broken NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0 Linux Tests (dbg)(2) and Win7 Tests (dbg)(1).
Will provide links and stdio on the new CL. This is speculative, if the issue won't go away, the revert will be reverted.

Original issue's description:
> Rename AudioRenderer::Play/Pause() to Start/StopRendering().
> 
> This makes a clearer separation between methods for controlling the
> actual rendering of audio versus methods for controlling the state of the
> renderer (i.e,. flushing and seeking).
> 
> Consequently, clean up AudioRendererImpl to reflect the separation
> between rendering methods and state change methods.
> 
> BUG=370634
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270017

TBR=dalecurtis@chromium.org,xhwang@google.com,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270037

[vabr (Chromium), 2014-05-13 06:51:21]

Created Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering().

[commit-bot: I haz the power, 2014-05-13 06:51:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vabr@chromium.org/274443006/1

[commit-bot: I haz the power, 2014-05-13 06:52:38]

Change committed as 270037

[vabr (Chromium), 2014-05-13 07:11:08]

On 2014/05/13 06:51:21, vabr (Chromium) wrote:
> Created Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering().

Bots (and first builds) which seem affected:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

The last one does not have this CL in the blamelist, though, so I'll keep
continue watching if the revert helps or not.

The stack trace for the failing test is:
[ RUN      ]
NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0
[1412:3976:0512/230347:1610008:FATAL:audio_renderer_impl.cc(142)] Check failed:
state_ == kPlaying (8 vs. 5)
Backtrace:
	base::debug::StackTrace::StackTrace [0x013F9FE1+33]
	logging::LogMessage::~LogMessage [0x014A164E+94]
	media::AudioRendererImpl::Flush [0x102238CE+478]
	base::internal::RunnableAdapter<void (__thiscall
media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const &)>::Run
[0x1019A898+40]
	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
(__thiscall media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const
&)>,void __cdecl(media::AudioRenderer *,base::Callback<void __cdecl(void)> const
&)>::MakeItSo [0x10197517+39]
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void
(__thiscall media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const
&)>,void __cdecl(media::AudioRenderer *,base::Callback<void __cdecl(void)> const
&),void [0x10199877+87]
	base::Callback<void __cdecl(base::Callback<void __cdecl(void)> const &)>::Run
[0x101A8E3C+60]
	media::SerialRunner::Run [0x101A95B6+534]
	base::internal::RunnableAdapter<void (__cdecl*)(base::Callback<void
__cdecl(base::Callback<void __cdecl(void)> const &)> const &,base::Callback<void
__cdecl(enum media::PipelineStatus)> const &)>::Run [0x101A9232+50]
	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
(__cdecl*)(base::Callback<void __cdecl(base::Callback<void __cdecl(void)> const
&)> const &,base::Callback<void __cdecl(enum media::PipelineStatus)> const
&)>,void __cdecl(base::Call [0x101A8865+37]
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void
(__cdecl*)(base::Callback<void __cdecl(base::Callback<void __cdecl(void)> const
&)> const &,base::Callback<void __cdecl(enum media::PipelineStatus)> const
&)>,void __ [0x101A8F52+82]
	base::Callback<void __cdecl(base::Callback<void __cdecl(enum
media::PipelineStatus)> const &)>::Run [0x101A8DCC+60]
	media::SerialRunner::RunNextInSeries [0x101A9972+786]
	media::SerialRunner::SerialRunner [0x101A7C81+385]
	media::SerialRunner::Run [0x101A9406+102]
	media::Pipeline::DoSeek [0x101948E2+1874]
	media::Pipeline::SeekTask [0x1019BCA3+1683]
	base::internal::RunnableAdapter<void (__thiscall
media::Pipeline::*)(base::TimeDelta,base::Callback<void __cdecl(enum
media::PipelineStatus)> const &)>::Run [0x1019AD3B+59]
	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
(__thiscall media::Pipeline::*)(base::TimeDelta,base::Callback<void __cdecl(enum
media::PipelineStatus)> const &)>,void __cdecl(media::Pipeline *,base::TimeDelta
const &,base::Callba [0x10197874+52]
	base::internal::Invoker<3,base::internal::BindState<base::internal::RunnableAdapter<void
(__thiscall media::Pipeline::*)(base::TimeDelta,base::Callback<void __cdecl(enum
media::PipelineStatus)> const &)>,void __cdecl(media::Pipeline
*,base::TimeDelta,base [0x1019A7FE+142]
	base::Callback<void __cdecl(void)>::Run [0x013CF19F+47]
	base::MessageLoop::RunTask [0x014DC291+881]
	base::MessageLoop::DeferOrRunPendingTask [0x014D8DA4+52]
	base::MessageLoop::DoWork [0x014D94C3+259]
	base::MessagePumpDefault::Run [0x014E17A6+262]
	base::MessageLoop::RunHandler [0x014DBE9A+314]
	base::RunLoop::Run [0x0155FA79+41]
	base::MessageLoop::Run [0x014DBCD1+81]
	media::PipelineIntegrationTestBase::Seek [0x009C5F33+211]
	media::PipelineIntegrationTest::TestSeekDuringRead [0x009BC594+292]
	media::PipelineIntegrationTest_ChunkDemuxerAbortRead_AudioOnly_Test::TestBody
[0x009B502D+221]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
[0x00B9A7D9+329]
	testing::Test::Run [0x00BB3BDE+174]
	testing::TestInfo::Run [0x00BB3E7D+221]
	testing::TestCase::Run [0x00BB3D1F+239]
	testing::internal::UnitTestImpl::RunAllTests [0x00BB42D6+726]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[0x00B9ACD1+337]
	testing::UnitTest::Run [0x00BB3FD3+211]
	RUN_ALL_TESTS [0x00B511BF+15]
	base::TestSuite::Run [0x00B51409+233]
	base::internal::RunnableAdapter<int (__thiscall base::TestSuite::*)(void)>::Run
[0x0072323B+27]
	base::internal::InvokeHelper<0,int,base::internal::RunnableAdapter<int
(__thiscall base::TestSuite::*)(void)>,void __cdecl(TestSuiteNoAtExit
*)>::MakeItSo [0x0072314A+26]
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<int
(__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
__cdecl(base::internal::UnretainedWrapper<TestSuiteNoAtExit>)>,int
__cdecl(base::TestSuite * [0x007231BA+74]
	base::Callback<int __cdecl(void)>::Run [0x00B4B1EF+47]
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x00B4A279+921]
	base::LaunchUnitTests [0x00B49EC5+37]
	main [0x0072332C+140]
	__tmainCRTStartup [0x00CEC0A9+409]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
	mainCRTStartup [0x00CEC1ED+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
	BaseThreadInitThunk [0x74DE338A+18]
	RtlInitializeExceptionChain [0x77379F72+99]
	RtlInitializeExceptionChain [0x77379F45+54]

[vabr (Chromium), 2014-05-13 07:49:50]

On 2014/05/13 07:11:08, vabr (Chromium) wrote:
> On 2014/05/13 06:51:21, vabr (Chromium) wrote:
> > Created Revert of Rename AudioRenderer::Play/Pause() to
Start/StopRendering().
> 
> Bots (and first builds) which seem affected:
>
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
> 
> The last one does not have this CL in the blamelist, though, so I'll keep
> continue watching if the revert helps or not.
> 
> The stack trace for the failing test is:
> [ RUN      ]
> NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0
> [1412:3976:0512/230347:1610008:FATAL:audio_renderer_impl.cc(142)] Check
failed:
> state_ == kPlaying (8 vs. 5)
> Backtrace:
> 	base::debug::StackTrace::StackTrace [0x013F9FE1+33]
> 	logging::LogMessage::~LogMessage [0x014A164E+94]
> 	media::AudioRendererImpl::Flush [0x102238CE+478]
> 	base::internal::RunnableAdapter<void (__thiscall
> media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const &)>::Run
> [0x1019A898+40]
> 	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
> (__thiscall media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const
> &)>,void __cdecl(media::AudioRenderer *,base::Callback<void __cdecl(void)>
const
> &)>::MakeItSo [0x10197517+39]
>
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void
> (__thiscall media::AudioRenderer::*)(base::Callback<void __cdecl(void)> const
> &)>,void __cdecl(media::AudioRenderer *,base::Callback<void __cdecl(void)>
const
> &),void [0x10199877+87]
> 	base::Callback<void __cdecl(base::Callback<void __cdecl(void)> const &)>::Run
> [0x101A8E3C+60]
> 	media::SerialRunner::Run [0x101A95B6+534]
> 	base::internal::RunnableAdapter<void (__cdecl*)(base::Callback<void
> __cdecl(base::Callback<void __cdecl(void)> const &)> const
&,base::Callback<void
> __cdecl(enum media::PipelineStatus)> const &)>::Run [0x101A9232+50]
> 	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
> (__cdecl*)(base::Callback<void __cdecl(base::Callback<void __cdecl(void)>
const
> &)> const &,base::Callback<void __cdecl(enum media::PipelineStatus)> const
> &)>,void __cdecl(base::Call [0x101A8865+37]
>
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void
> (__cdecl*)(base::Callback<void __cdecl(base::Callback<void __cdecl(void)>
const
> &)> const &,base::Callback<void __cdecl(enum media::PipelineStatus)> const
> &)>,void __ [0x101A8F52+82]
> 	base::Callback<void __cdecl(base::Callback<void __cdecl(enum
> media::PipelineStatus)> const &)>::Run [0x101A8DCC+60]
> 	media::SerialRunner::RunNextInSeries [0x101A9972+786]
> 	media::SerialRunner::SerialRunner [0x101A7C81+385]
> 	media::SerialRunner::Run [0x101A9406+102]
> 	media::Pipeline::DoSeek [0x101948E2+1874]
> 	media::Pipeline::SeekTask [0x1019BCA3+1683]
> 	base::internal::RunnableAdapter<void (__thiscall
> media::Pipeline::*)(base::TimeDelta,base::Callback<void __cdecl(enum
> media::PipelineStatus)> const &)>::Run [0x1019AD3B+59]
> 	base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
> (__thiscall media::Pipeline::*)(base::TimeDelta,base::Callback<void
__cdecl(enum
> media::PipelineStatus)> const &)>,void __cdecl(media::Pipeline
*,base::TimeDelta
> const &,base::Callba [0x10197874+52]
>
	base::internal::Invoker<3,base::internal::BindState<base::internal::RunnableAdapter<void
> (__thiscall media::Pipeline::*)(base::TimeDelta,base::Callback<void
__cdecl(enum
> media::PipelineStatus)> const &)>,void __cdecl(media::Pipeline
> *,base::TimeDelta,base [0x1019A7FE+142]
> 	base::Callback<void __cdecl(void)>::Run [0x013CF19F+47]
> 	base::MessageLoop::RunTask [0x014DC291+881]
> 	base::MessageLoop::DeferOrRunPendingTask [0x014D8DA4+52]
> 	base::MessageLoop::DoWork [0x014D94C3+259]
> 	base::MessagePumpDefault::Run [0x014E17A6+262]
> 	base::MessageLoop::RunHandler [0x014DBE9A+314]
> 	base::RunLoop::Run [0x0155FA79+41]
> 	base::MessageLoop::Run [0x014DBCD1+81]
> 	media::PipelineIntegrationTestBase::Seek [0x009C5F33+211]
> 	media::PipelineIntegrationTest::TestSeekDuringRead [0x009BC594+292]
> 	media::PipelineIntegrationTest_ChunkDemuxerAbortRead_AudioOnly_Test::TestBody
> [0x009B502D+221]
> 	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
> [0x00B9A7D9+329]
> 	testing::Test::Run [0x00BB3BDE+174]
> 	testing::TestInfo::Run [0x00BB3E7D+221]
> 	testing::TestCase::Run [0x00BB3D1F+239]
> 	testing::internal::UnitTestImpl::RunAllTests [0x00BB42D6+726]
>
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
> [0x00B9ACD1+337]
> 	testing::UnitTest::Run [0x00BB3FD3+211]
> 	RUN_ALL_TESTS [0x00B511BF+15]
> 	base::TestSuite::Run [0x00B51409+233]
> 	base::internal::RunnableAdapter<int (__thiscall
base::TestSuite::*)(void)>::Run
> [0x0072323B+27]
> 	base::internal::InvokeHelper<0,int,base::internal::RunnableAdapter<int
> (__thiscall base::TestSuite::*)(void)>,void __cdecl(TestSuiteNoAtExit
> *)>::MakeItSo [0x0072314A+26]
>
	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<int
> (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
> __cdecl(base::internal::UnretainedWrapper<TestSuiteNoAtExit>)>,int
> __cdecl(base::TestSuite * [0x007231BA+74]
> 	base::Callback<int __cdecl(void)>::Run [0x00B4B1EF+47]
> 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x00B4A279+921]
> 	base::LaunchUnitTests [0x00B49EC5+37]
> 	main [0x0072332C+140]
> 	__tmainCRTStartup [0x00CEC0A9+409]
> (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
> 	mainCRTStartup [0x00CEC1ED+13]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
> 	BaseThreadInitThunk [0x74DE338A+18]
> 	RtlInitializeExceptionChain [0x77379F72+99]
> 	RtlInitializeExceptionChain [0x77379F45+54]

OK, now
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
succeeded, even though the revert was not in. The tests is probably flaky. I'll
wait for the other builders to see their situation, but I'm starting to consider
revert of this revert.

[vabr (Chromium), 2014-05-13 08:43:24]

Final update:

In the end I decided to keep the revert in. The failing
NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0 test
does not 100% occur within the range r270017 (reverted patch) - r270037
(revert), but it had not been there before r270017, and it did not come back
after r270037:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

My conclusion is that it might have been flakily triggered by r270017. Because
I'm not familiar with the code in question, I'd like you to reconsider if there
can be a link between r270017 and the failing test or not, and re-land or fix as
appropriate.

Sorry about the trouble.
Vaclav, your friendly Chromium sheriff