Implement PreauthorizePermission

android_webview/native/permission/permission_request_handler.h

Index: android_webview/native/permission/permission_request_handler.h
diff --git a/android_webview/native/permission/permission_request_handler.h b/android_webview/native/permission/permission_request_handler.h
index d4d91b64bfc6738f2aa4c095b343831fbcd03946..3acb497654edca30f9396b8cd1e79663f6b4a367 100644
--- a/android_webview/native/permission/permission_request_handler.h
+++ b/android_webview/native/permission/permission_request_handler.h
@@ -5,6 +5,7 @@
 #ifndef ANDROID_WEBVIEW_NATIVE_PERMISSION_PERMISSION_REQUEST_HANDLER_H
 #define ANDROID_WEBVIEW_NATIVE_PERMISSION_PERMISSION_REQUEST_HANDLER_H
 
+#include <map>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ -32,6 +33,9 @@ class PermissionRequestHandler {
   // Cancel the ongoing request initiated by |origin| for accessing |resources|.
   void CancelRequest(const GURL& origin, int64 resources);
 
+  // Allow |origin| to access the |resources|.
+  void PreauthorizePermission(const GURL& origin, int64 resources);
+
  private:
   friend class TestPermissionRequestHandler;
 
@@ -47,11 +51,16 @@ class PermissionRequestHandler {
   // Remove the invalid requests from requests_.
   void PruneRequests();
 
+  // Return true if |origin| were preauthorized to access |resources|.
+  bool Preauthorized(const GURL& origin, int64 resources);

[benm (inactive), 2014/05/08 14:50:21]

nit: isPreauthorized?

oh, just seen that Marcin had the same comment in the previous round. I think
this is nicer, doesn't chromium normally name methods like this?

[michaelbai, 2014/05/08 16:44:30]

There is no constant usage. I prefer to use Is+adj/noun and past participle, 
like IsVisiable(), Allowed() and Preauthorized here. 


On 2014/05/08 14:50:21, benm wrote:

+
   PermissionRequestHandlerClient* client_;
 
   // A list of ongoing requests.
   std::vector<base::WeakPtr<AwPermissionRequest> > requests_;
 
+  std::map<std::string, int64> preauthorized_permission_;
+
   DISALLOW_COPY_AND_ASSIGN(PermissionRequestHandler);
 };