Implement PreauthorizePermission

android_webview/native/permission/permission_request_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/permission/aw_permission_request.h"
 #include "android_webview/native/permission/aw_permission_request_delegate.h"
 #include "android_webview/native/permission/permission_request_handler.h"
 #include "android_webview/native/permission/permission_request_handler_client.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 36 matching lines @@
   struct Permission {
     Permission()
         :resources(0) {}
     Permission(const GURL& origin, int64 resources)
         : origin(origin),
           resources(resources) {}
     GURL origin;
     int64 resources;
   };
 
+  TestPermissionRequestHandlerClient()
+      : request_(NULL) {}
+
   virtual void OnPermissionRequest(AwPermissionRequest* request) OVERRIDE {
     request_ = request;
     requested_permission_ =
         Permission(request->GetOrigin(), request->GetResources());
   }
 
   virtual void OnPermissionRequestCanceled(
       AwPermissionRequest* request) OVERRIDE{
     canceled_permission_ =
         Permission(request->GetOrigin(), request->GetResources());
@@ skipping 14 matching lines @@
   void Grant() {
     request_->OnAccept(NULL, NULL, true);
     request_ = NULL;
   }
 
   void Deny() {
     request_->OnAccept(NULL, NULL, false);
     request_ = NULL;
   }
 
+  void Reset() {
+    request_ = NULL;
+    requested_permission_ = Permission();
+    canceled_permission_ = Permission();
+  }
+
  private:
   AwPermissionRequest* request_;
   Permission requested_permission_;
   Permission canceled_permission_;
 };
 
 class TestPermissionRequestHandler : public PermissionRequestHandler {
  public:
   TestPermissionRequestHandler(PermissionRequestHandlerClient* client)
       : PermissionRequestHandler(client) {
@@ skipping 158 matching lines @@
   // Verify client's OnPermissionRequestCancled() was called.
   EXPECT_EQ(origin(), client()->canceled_permission().origin);
   EXPECT_EQ(resources(), client()->canceled_permission().resources);
   // Verify Handler store the request correctly, the 1st and 3rd were removed.
   handler()->PruneRequests();
   ASSERT_EQ(1u, handler()->requests().size());
   EXPECT_EQ(origin1, handler()->requests()[0]->GetOrigin());
   EXPECT_EQ(resources1, handler()->requests()[0]->GetResources());
 }
 
+TEST_F(PermissionRequestHandlerTest, TestPreauthorizePermission) {
+  handler()->PreauthorizePermission(origin(), resources());
+
+  // Permission should granted without asking PermissionRequestHandlerClient.
+  handler()->SendRequest(delegate().Pass());
+  EXPECT_TRUE(allowed());
+  EXPECT_EQ(NULL, client()->request());
+
+  // Only ask one preauthorized resource, permission should granted
+  // without asking PermissionRequestHandlerClient.
+  scoped_ptr<AwPermissionRequestDelegate> delegate1;

[benm (inactive), 2014/05/07 17:01:21]

Any need for the '1'?

+  delegate1.reset(new TestAwPermissionRequestDelegate(
+      origin(), AwPermissionRequest::AudioCapture,
+      base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
+                 base::Unretained(this))));
+  client()->Reset();
+  handler()->SendRequest(delegate1.Pass());
+  EXPECT_TRUE(allowed());
+  EXPECT_EQ(NULL, client()->request());
+
+  // Ask the origin which wasn't preauthorized.
+  GURL origin1 ("http://a.google.com/a/b");
+  delegate1.reset(new TestAwPermissionRequestDelegate(
+      origin1, AwPermissionRequest::AudioCapture,
+      base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
+                 base::Unretained(this))));
+  client()->Reset();
+  handler()->SendRequest(delegate1.Pass());
+  EXPECT_EQ(origin1, handler()->requests()[0]->GetOrigin());
+  EXPECT_EQ(AwPermissionRequest::AudioCapture,
+            handler()->requests()[0]->GetResources());
+  client()->Grant();
+  EXPECT_TRUE(allowed());
+
+  // Ask the resources which weren't preauthorized.

[benm (inactive), 2014/05/07 17:01:21]

would it make sense to split this into two test cases?

[mkosiba (inactive), 2014/05/07 17:25:50]

or 4 even?

+  delegate1.reset(new TestAwPermissionRequestDelegate(
+      origin(),
+      AwPermissionRequest::AudioCapture | AwPermissionRequest::Geolocation,
+      base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
+                 base::Unretained(this))));
+  client()->Reset();
+  handler()->SendRequest(delegate1.Pass());
+  EXPECT_EQ(origin(), handler()->requests()[0]->GetOrigin());
+  EXPECT_EQ(
+      AwPermissionRequest::AudioCapture | AwPermissionRequest::Geolocation,
+      handler()->requests()[0]->GetResources());
+  client()->Deny();
+  EXPECT_FALSE(allowed());
+
+  // Preauthorize another permission.
+  handler()->PreauthorizePermission(origin1, AwPermissionRequest::Geolocation);
+  GURL origin1_hostname ("http://a.google.com/");
+  delegate1.reset(new TestAwPermissionRequestDelegate(
+      origin1_hostname, AwPermissionRequest::Geolocation,
+      base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
+                 base::Unretained(this))));
+  client()->Reset();
+  handler()->SendRequest(delegate1.Pass());
+  EXPECT_TRUE(allowed());
+  EXPECT_EQ(NULL, client()->request());
+}
+
 }  // android_webview