Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: ui/gfx/skrect_conversion_unittest.cc

Issue 2744423002: Handle large rects better. (Closed)
Patch Set: Rebased on size patch Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/geometry/rect_unittest.cc ('K') | « ui/gfx/skia_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/skrect_conversion_unittest.cc
diff --git a/ui/gfx/skrect_conversion_unittest.cc b/ui/gfx/skrect_conversion_unittest.cc
index f9c05c04589fb1506e3d8be70f3253105c73790e..e8bd4f4936197cffcfb0be3161abe89b9177d3d8 100644
--- a/ui/gfx/skrect_conversion_unittest.cc
+++ b/ui/gfx/skrect_conversion_unittest.cc
@@ -33,10 +33,10 @@ TEST(RectTest, SkIRectToRectClamping) {
// right-left and bottom-top would overflow.
// These should be mapped to max width/height, which is as close as gfx::Rect
// can represent.
- EXPECT_EQ(
- gfx::Rect(Limits::min(), Limits::min(), Limits::max(), Limits::max()),
- SkIRectToRect(SkIRect::MakeLTRB(Limits::min(), Limits::min(),
- Limits::max(), Limits::max())));
+ EXPECT_EQ(gfx::Size(Limits::max(), Limits::max()),
+ SkIRectToRect(SkIRect::MakeLTRB(Limits::min(), Limits::min(),
danakj 2017/03/28 20:40:35 This would be more readable (less line-wrappy) if
Peter Mayo 2017/03/29 18:49:26 Done.
+ Limits::max(), Limits::max()))
+ .size());
// right-left and bottom-top would underflow.
// These should be mapped to zero, like all negative values.
« ui/gfx/geometry/rect_unittest.cc ('K') | « ui/gfx/skia_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698