Handle large rects better.

ui/gfx/skrect_conversion_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/skia_util.h"
 
 namespace gfx {
 
@@ skipping 15 matching lines @@
   // This clamping only makes sense if SkIRect and gfx::Rect have the same size.
   // Otherwise, either other overflows can occur that we don't handle, or no
   // overflows can ocur.
   if (sizeof(int) != sizeof(int32_t))
     return;
   using Limits = std::numeric_limits<int>;
 
   // right-left and bottom-top would overflow.
   // These should be mapped to max width/height, which is as close as gfx::Rect
   // can represent.
-  EXPECT_EQ(
-      gfx::Rect(Limits::min(), Limits::min(), Limits::max(), Limits::max()),
-      SkIRectToRect(SkIRect::MakeLTRB(Limits::min(), Limits::min(),
-                                      Limits::max(), Limits::max())));
+  EXPECT_EQ(gfx::Size(Limits::max(), Limits::max()),
+            SkIRectToRect(SkIRect::MakeLTRB(Limits::min(), Limits::min(),

[danakj, 2017/03/28 20:40:35]

This would be more readable (less line-wrappy) if you put the result into a
local Rect var before comparing

[Peter Mayo, 2017/03/29 18:49:26]

Done.

+                                            Limits::max(), Limits::max()))
+                .size());
 
   // right-left and bottom-top would underflow.
   // These should be mapped to zero, like all negative values.
   EXPECT_EQ(gfx::Rect(Limits::max(), Limits::max(), 0, 0),
             SkIRectToRect(SkIRect::MakeLTRB(Limits::max(), Limits::max(),
                                             Limits::min(), Limits::min())));
 }
 
 }  // namespace gfx