Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: test/cctest/wasm/test-wasm-trap-position.cc

Issue 2744383002: Revert of [wasm] Initial signal handler (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-wasm-trap-position.cc
diff --git a/test/cctest/wasm/test-wasm-trap-position.cc b/test/cctest/wasm/test-wasm-trap-position.cc
index 7b953834b8ae1a622648dcea4d9eed47c7765910..91159f21548211af02f19ee4c7efd839e5b92b3b 100644
--- a/test/cctest/wasm/test-wasm-trap-position.cc
+++ b/test/cctest/wasm/test-wasm-trap-position.cc
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "src/assembler-inl.h"
-#include "src/trap-handler/trap-handler.h"
#include "src/wasm/wasm-macro-gen.h"
#include "test/cctest/cctest.h"
#include "test/cctest/compiler/value-helper.h"
@@ -99,14 +98,6 @@
// Trigger a trap for loading from out-of-bounds.
TEST(IllegalLoad) {
- if (trap_handler::UseTrapHandler()) {
- // r.module().AddMemory() does not allocate guard pages, so we skip this
- // test for now when using trap handlers. The simple out of bounds access
- // case is covered by mjsunit tests, so we are still getting test coverage.
- //
- // TODO(eholk): make this test work with trap handlers.
- return;
- }
WasmRunner<void> r(kExecuteCompiled);
TestSignatures sigs;
// Set the execution context, such that a runtime error can be thrown.
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698