Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/trap-handler/handler-shared.cc

Issue 2744383002: Revert of [wasm] Initial signal handler (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trap-handler/handler-outside.cc ('k') | src/trap-handler/trap-handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trap-handler/handler-shared.cc
diff --git a/src/trap-handler/handler-shared.cc b/src/trap-handler/handler-shared.cc
deleted file mode 100644
index 7b399f5eeac1be04c540cc576ec2bc4b448f5535..0000000000000000000000000000000000000000
--- a/src/trap-handler/handler-shared.cc
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright 2017 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// PLEASE READ BEFORE CHANGING THIS FILE!
-//
-// This file contains code that is used both inside and outside the out of
-// bounds signal handler. Because this code runs in a signal handler context,
-// use extra care when modifying this file. Here are some rules to follow.
-//
-// 1. Do not introduce any new external dependencies. This file needs
-// to be self contained so it is easy to audit everything that a
-// signal handler might do.
-//
-// 2. Any changes must be reviewed by someone from the crash reporting
-// or security team. See OWNERS for suggested reviewers.
-//
-// For more information, see https://goo.gl/yMeyUY.
-
-#include "src/trap-handler/trap-handler-internal.h"
-
-namespace v8 {
-namespace internal {
-namespace trap_handler {
-
-THREAD_LOCAL bool g_thread_in_wasm_code = false;
-
-size_t gNumCodeObjects = 0;
-CodeProtectionInfoListEntry* gCodeObjects = nullptr;
-
-std::atomic_flag MetadataLock::spinlock_ = ATOMIC_FLAG_INIT;
-
-MetadataLock::MetadataLock() {
- if (g_thread_in_wasm_code) {
- abort();
- }
-
- while (spinlock_.test_and_set(std::memory_order::memory_order_acquire)) {
- }
-}
-
-MetadataLock::~MetadataLock() {
- if (g_thread_in_wasm_code) {
- abort();
- }
-
- spinlock_.clear(std::memory_order::memory_order_release);
-}
-
-} // namespace trap_handler
-} // namespace internal
-} // namespace v8
« no previous file with comments | « src/trap-handler/handler-outside.cc ('k') | src/trap-handler/trap-handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698