Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: client/tools/buildbot_annotated_steps.py

Issue 27443003: Get Windows Editor buildbot running with correct java again. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/buildbot_annotated_steps.py
diff --git a/client/tools/buildbot_annotated_steps.py b/client/tools/buildbot_annotated_steps.py
index 1c88a66cf2dfbafa6da47607ae30dcc2f4fe7986..21f2e48893b8af819fcb87c77f2099dcba39aa38 100755
--- a/client/tools/buildbot_annotated_steps.py
+++ b/client/tools/buildbot_annotated_steps.py
@@ -15,6 +15,7 @@ chromium and headless dartium.
import imp
import os
+import platform
import re
import socket
import subprocess
@@ -134,7 +135,10 @@ def FixJavaHome():
buildbot_javahome = os.getenv('BUILDBOT_JAVA_HOME')
if buildbot_javahome:
current_pwd = os.getenv('PWD')
- java_home = '/usr/lib/jvm/java-6-sun'#os.path.join(current_pwd, buildbot_javahome)
+ if platform.system() != 'Windows':
+ java_home = '/usr/lib/jvm/java-6-sun' # Hackety-hack. Please remove!
+ else:
+ java_home = os.path.join(current_pwd, buildbot_javahome)
java_bin = os.path.join(java_home, 'bin')
os.environ['JAVA_HOME'] = java_home
os.environ['PATH'] = '%s;%s' % (java_bin, os.environ['PATH'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698