Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2744113002: Change the calling conventions for Parser.reportUnrecoverableError. (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the calling conventions for Parser.reportUnrecoverableError. As with a6804167162f230bf8498289a61dc7efebf32b0c, we change the calling conventions so that the return value is a token whose "next" pointer points to the token from which parsing should proceed. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/59b3ca5fa249fed8d8401535792df662d4566fc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -34 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 23 chunks +45 lines, -33 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 9 months ago (2017-03-11 14:51:12 UTC) #2
ahe
lgtm
3 years, 9 months ago (2017-03-13 12:09:16 UTC) #3
Paul Berry
3 years, 9 months ago (2017-03-13 17:48:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59b3ca5fa249fed8d8401535792df662d4566fc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698