Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2744043003: Use LoadLibraryExW if applicable in LoadNativeLibrary on Windows (Closed)
Patch Set: Add a wrapper method for UMA. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« base/native_library_win.cc ('K') | « base/native_library_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a61d57ec74803a23df4b7a9418c169f5d7fc6e6c..a2f0b0bcd5601049d3bc9aff5d5f05c2c5772ab9 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -24514,6 +24514,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="LibraryLoader.NativeLibraryDynamicallyLoad"
+ enum="LoadLibraryResultCategory">
+ <owner>chengx@chromium.org</owner>
+ <summary>
+ This metric records the LoadLibraryExW and LoadLibraryW Windows API call
+ results, which are used in LoadNativeLibraryDynamically method in
Ilya Sherman 2017/03/14 18:42:28 nit: s/used in/used in
xhwang 2017/03/14 21:48:25 LoadNativeLibraryDynamically is not true now...
chengx 2017/03/14 23:08:30 Renamed.
chengx 2017/03/14 23:08:30 Done.
+ native_library_win.cc.
+ </summary>
+</histogram>
+
<histogram name="LibraryLoader.NativeLibraryHack" enum="BooleanUsage">
<obsolete>
Deprecated as of 11/2014, removed from code.
@@ -98778,6 +98788,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="23" label="Unnamed"/>
</enum>
+<enum name="LoadLibraryResultCategory" type="int">
+ <int value="0" label="LoadLibraryExW Succeed"/>
Ilya Sherman 2017/03/14 18:42:28 nit: either "Succeeded" or "Success"
chengx 2017/03/14 23:08:30 Done.
+ <int value="1" label="LoadLibraryExW Fail, LoadLibraryW Succeed"/>
+ <int value="2" label="LoadLibraryExW Fail, LoadLibraryW Fail"/>
+ <int value="3" label="LoadLibraryExW Unavailable, LoadLibraryW Succeed"/>
+ <int value="4" label="LoadLibraryExW Unavailable, LoadLibraryW Fail"/>
+</enum>
+
<enum name="LoadType" type="int">
<int value="0" label="UNDEFINED_LOAD">Not yet initialized</int>
<int value="1" label="RELOAD">User pressed reload</int>
« base/native_library_win.cc ('K') | « base/native_library_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698