Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 274403003: Change some DCHECKs into CHECKs to track down a crash. (Closed)

Created:
6 years, 7 months ago by Ryan Hamilton
Modified:
6 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Change some DCHECKs into CHECKs to track down a crash. BUG=362729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Hamilton
6 years, 7 months ago (2014-05-14 18:38:53 UTC) #1
Peter Kasting
LGTM
6 years, 7 months ago (2014-05-14 18:39:06 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 7 months ago (2014-05-15 17:47:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/274403003/1
6 years, 7 months ago (2014-05-15 17:49:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 20:11:50 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 21:21:27 UTC) #6
Message was sent while issue was closed.
Change committed as 270820

Powered by Google App Engine
This is Rietveld 408576698