base/trace_event/memory_dump_manager_unittest.cc - Issue 2743993004: [memory-infra] Make MemoryDumpScheduler non-thread safe singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 2743993004: [memory-infra] Make MemoryDumpScheduler non-thread safe singleton (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_dump_manager_unittest.cc

diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc

index 51d41943fba0416fd9ad5f167d78cbbbdbc51a1c..51ca3b92b5ea2525ea4969c498ae1c3dbf30cab4 100644

--- a/base/trace_event/memory_dump_manager_unittest.cc

+++ b/base/trace_event/memory_dump_manager_unittest.cc

@@ -274,7 +274,8 @@ class MemoryDumpManagerTest : public testing::Test {

void DisableTracing() { TraceLog::GetInstance()->SetDisabled(); }

bool IsPeriodicDumpingEnabled() const {

- return mdm_->dump_scheduler_->IsPeriodicTimerRunningForTesting();

+ return MemoryDumpScheduler::GetInstance()

+ ->IsPeriodicTimerRunningForTesting();

}

int GetMaxConsecutiveFailuresCount() const {