chrome/browser/ui/cocoa/tabs/tab_controller.mm - Issue 2743993003: cocoa: add experimental tabstrip keyboard focus support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_controller.mm

Issue 2743993003: cocoa: add experimental tabstrip keyboard focus support (Closed)

Patch Set: fix histogram Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tabs/tab_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

index 240d109a1015dbd751eaa87b74e9ce2841d969b1..ec6ca25d6c22845873572183cee2b2988a75ac54 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

@@ -490,4 +490,10 @@ - (void)maybeStartDrag:(NSEvent*)event forTab:(TabController*)tab {

[[target_ dragController] maybeStartDrag:event forTab:tab];

}

+- (void)keyUp:(NSEvent*)event {

+ unichar keyChar = [[event characters] characterAtIndex:0];

+ if (keyChar == '\r' || keyChar == '\n')

+ [self selectTab:self];

@end

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/cocoa/tabs/tab_view.mm » ('j') | no next file with comments »