Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2743963002: Correctly handle abstract non-sync methods. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-10 16:46:37 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-13 11:34:41 UTC) #3
ahe
3 years, 9 months ago (2017-03-13 12:33:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e12e5350b120de00b9e504ee850617de50dba220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698