Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5044)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2743923003: Revert "Make Crashpad start asynchronous, and move back to chrome_elf" (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 765ca4223de2f44e9458ee40b18479404a510d4f..8ee0da30a9d9dd7b566bf39335ae92487e4c3b37 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -211,7 +211,6 @@
#include "chrome/browser/win/browser_util.h"
#include "chrome/browser/win/chrome_select_file_dialog_factory.h"
#include "chrome/install_static/install_util.h"
-#include "components/crash/content/app/crashpad.h"
#include "ui/base/l10n/l10n_util_win.h"
#include "ui/shell_dialogs/select_file_dialog.h"
#endif // defined(OS_WIN)
@@ -1417,18 +1416,6 @@ void ChromeBrowserMainParts::PostBrowserStart() {
int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreMainMessageLoopRunImpl");
-#if defined(OS_WIN)
- HMODULE chrome_elf = GetModuleHandle(chrome::kChromeElfDllName);
- if (chrome_elf) {
- auto block_until_handler_started = reinterpret_cast<void (*)()>(
- GetProcAddress(chrome_elf, "BlockUntilHandlerStartedImpl"));
- if (block_until_handler_started) {
- SCOPED_UMA_HISTOGRAM_TIMER("Startup.BlockForCrashpadHandlerStartupTime");
- block_until_handler_started();
- }
- }
-#endif
-
SCOPED_UMA_HISTOGRAM_LONG_TIMER("Startup.PreMainMessageLoopRunImplLongTime");
const base::TimeTicks start_time_step1 = base::TimeTicks::Now();

Powered by Google App Engine
This is Rietveld 408576698