build/android/pylib/local/device/local_device_test_run.py - Issue 2743873003: [Android] Add support for external sharding to the test runner.

Unified Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 2743873003: [Android] Add support for external sharding to the test runner. (Closed)

Patch Set: fix instrumentation tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/local/device/local_device_test_run.py

diff --git a/build/android/pylib/local/device/local_device_test_run.py b/build/android/pylib/local/device/local_device_test_run.py

index 1d7ebdf802802258f1c5d275e0b60b69913db8f2..5288fb32be32eade57e06725ff1948cd94d87f37 100644

--- a/build/android/pylib/local/device/local_device_test_run.py

+++ b/build/android/pylib/local/device/local_device_test_run.py

@@ -177,6 +177,11 @@ class LocalDeviceTestRun(test_run.TestRun):

return [t for t in failed_tests if self._ShouldRetry(t)]

+ def _ApplyExternalSharding(self, tests, shard_index, total_shards):

bpastene 2017/03/14 01:03:46 It might be helpful to log the shard args here. I

jbudorick 2017/03/14 15:36:01 Done.

+ return [

bpastene 2017/03/14 01:03:46 Any interest in complaining and/or exploding if sh

jbudorick 2017/03/14 15:36:00 Done.

+ t for t in tests

+ if hash(self._GetUniqueTestName(t)) % total_shards == shard_index]

mikecase (-- gone --) 2017/03/13 18:44:50 I was curious how uniform the distribution of "has

jbudorick 2017/03/13 19:02:20 What I have here is also: - consistent with how b

def GetTool(self, device):

if not str(device) in self._tools:

self._tools[str(device)] = valgrind_tools.CreateTool(