Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2743863002: MD Settings: fix toggle button spacing (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_toggle_button.html
diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.html b/chrome/browser/resources/settings/controls/settings_toggle_button.html
index 6866a2a7f9dda122c13d43f0b8b56b3f59eaf166..5569b613f7db05621f3d148f7f1164bb3c585070 100644
--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html
+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html
@@ -28,18 +28,16 @@
min-height: var(--settings-row-min-height);
}
- paper-toggle-button,
+ #labelWrapper,
+ ::content .more-actions,
scottchen 2017/03/10 19:05:46 that's cool, didn't know about ::content.
Dan Beam 2017/03/10 19:14:10 it's probably going away soon, don't get used to i
cr-policy-pref-indicator {
- -webkit-margin-start: var(--checkbox-spacing);
- }
-
- ::content .more-actions {
- -webkit-margin-end: 10px;
+ -webkit-margin-end: var(--checkbox-spacing);
}
</style>
<div id="outerRow" noSubLabel$="[[!subLabel]]">
- <div class="flex" on-tap="onLabelWrapperTap_"
- actionable$="[[!controlDisabled_(disabled, pref.*)]]">
+ <div class="flex" id="labelWrapper" on-tap="onLabelWrapperTap_"
+ actionable$="[[!controlDisabled_(disabled, pref.*)]]"
+ hidden="[[!label]]">
scottchen 2017/03/10 19:05:46 would dom-if be better here?
Dan Beam 2017/03/10 19:14:10 for a couple <div>s, probably not
<div id="label" class="label">[[label]]</div>
<div class="secondary label">[[subLabel]]</div>
</div>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698