Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5575)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2743793003: Fix theme change paint issue on linux. (Closed)
Patch Set: Revert changes to DesktopWindowTreeHostWin Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 46e8977a8fff9c8369ea8aa87166f2d5ea1f1121..2a7c3d31bcb2637529d4ba08fcd4ee5fba026494 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1656,6 +1656,16 @@ base::string16 BrowserView::GetAccessibleTabLabel(bool include_app_name,
return base::string16();
}
+void BrowserView::NativeThemeUpdated(const ui::NativeTheme* theme) {
sky 2017/03/13 15:41:42 Please comment why NativeThemeUpdated is used rath
ananta 2017/03/13 19:48:03 Done.
+ // Do not handle native theme changes before the browser view is initialized.
+ if (!initialized_)
+ return;
+ // Don't infinitely recurse.
+ if (!handling_theme_changed_)
+ UserChangedTheme();
+ chrome::MaybeShowInvertBubbleView(this);
+}
+
views::View* BrowserView::GetInitiallyFocusedView() {
return nullptr;
}
@@ -1990,17 +2000,6 @@ void BrowserView::OnThemeChanged() {
views::View::OnThemeChanged();
}
-void BrowserView::OnNativeThemeChanged(const ui::NativeTheme* theme) {
- // Do not handle native theme changes before the browser view is initialized.
- if (!initialized_)
- return;
- ClientView::OnNativeThemeChanged(theme);
- // Don't infinitely recurse.
- if (!handling_theme_changed_)
- UserChangedTheme();
- chrome::MaybeShowInvertBubbleView(this);
-}
-
///////////////////////////////////////////////////////////////////////////////
// BrowserView, ui::AcceleratorTarget overrides:

Powered by Google App Engine
This is Rietveld 408576698