Issue 2743783002: [ash-md] Disables the Wi-Fi and Cellular toggles until the state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2743783002: [ash-md] Disables the Wi-Fi and Cellular toggles until the state changes (Closed)

Created:
3 years, 9 months ago by varkha

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

More Reviews

Description

[ash-md] Disables the Wi-Fi and Cellular toggles until the state changes BUG=687922 TEST=Visual On a mobile-equipped Chromebook (e.g. link with 3G) Try to toggle Mobile toggle off and immediately on Expected: The toggle cannot be re-enabled immediately. When it can finally be re-enabled, it stays enabled. Review-Url: https://codereview.chromium.org/2702493002 Cr-Commit-Position: refs/heads/master@{#455357} (cherry picked from commit 6a8e668da879ad1fc3b442a8c9a2be69b1a9a692) Landed as https://chromium.googlesource.com/chromium/src/+/83c7f2bc6aa21a29fbf37ec1eda83dfac1570cfe Cr-Commit-Position: refs/branch-heads/3029@{#92} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	ash/common/system/chromeos/bluetooth/tray_bluetooth.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ash/common/system/chromeos/network/network_list_md.cc	View		4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

varkha

3 years, 9 months ago (2017-03-15 13:17:50 UTC) #1

Description was changed from

==========
[ash-md] Disables the Wi-Fi and Cellular toggles until the state changes

BUG=687922
TEST=Visual
     On a mobile-equipped Chromebook (e.g. link with 3G)
     Try to toggle Mobile toggle off and immediately on
     Expected: The toggle cannot be re-enabled immediately.
     When it can finally be re-enabled, it stays enabled.

Review-Url: https://codereview.chromium.org/2702493002
Cr-Commit-Position: refs/heads/master@{#455357}
(cherry picked from commit 6a8e668da879ad1fc3b442a8c9a2be69b1a9a692)
==========

to

==========
[ash-md] Disables the Wi-Fi and Cellular toggles until the state changes

BUG=687922
TEST=Visual
     On a mobile-equipped Chromebook (e.g. link with 3G)
     Try to toggle Mobile toggle off and immediately on
     Expected: The toggle cannot be re-enabled immediately.
     When it can finally be re-enabled, it stays enabled.

Review-Url: https://codereview.chromium.org/2702493002
Cr-Commit-Position: refs/heads/master@{#455357}
(cherry picked from commit 6a8e668da879ad1fc3b442a8c9a2be69b1a9a692)

Landed as
https://chromium.googlesource.com/chromium/src/+/83c7f2bc6aa21a29fbf37ec1eda8...
Cr-Commit-Position: refs/branch-heads/3029@{#92}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages