Port part of media.tough_video_cases to TBMv2

tools/perf/benchmarks/media.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from core import perf_benchmark
 
 from telemetry import benchmark
 from telemetry.page import legacy_page_test
+from telemetry.timeline import chrome_trace_category_filter
 from telemetry.value import list_of_scalar_values
 from telemetry.value import scalar
+from telemetry.web_perf import timeline_based_measurement
 
 from measurements import media
 import page_sets
 
 
 class _MSEMeasurement(legacy_page_test.LegacyPageTest):
 
   def __init__(self):
     super(_MSEMeasurement, self).__init__()
 
@@ skipping 22 matching lines @@
 class Media(perf_benchmark.PerfBenchmark):
   """Obtains media metrics for key user scenarios."""
   test = media.Media
   page_set = page_sets.ToughVideoCasesPageSet
 
   @classmethod
   def Name(cls):
     return 'media.tough_video_cases'
 
 
+class Media2(perf_benchmark.PerfBenchmark):

[CalebRouleau, 2017/03/09 21:58:39]

How about Media_TBMv2 similar to my comment below?

+  """Obtains media metrics using TBMv2. Will eventually replace Media class."""
+  page_set = page_sets.ToughVideoCasesPageSet
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    categories = [
+        # For cpuTimeMetric:
+        'toplevel',
+    ]
+    category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
+        ','.join(['-*'] + categories))
+    options = timeline_based_measurement.Options(category_filter)
+    options.SetTimelineBasedMetrics( ['cpuTimeMetric'])

[CalebRouleau, 2017/03/09 22:00:22]

Remove extra space

+    return options
+
+  @classmethod
+  def Name(cls):
+    return 'media.tough_video_cases2'

[CalebRouleau, 2017/03/09 21:58:39]

I think it is worth naming this 

'media.tough_video_cases_tbmv2'

similar to 'v8.infinite_scroll_tbmv2'
https://cs.chromium.org/chromium/src/tools/perf/benchmarks/v8.py?l=172

Once the current media.tough_video_cases is removed, we can rename
'media.tough_video_cases_tbmv2' to 'media.tough_video_cases'

I think this will make the code clearly. Please feel free to push back if you
have a different opinion. :)

+
+
 # crbug.com/565180: Only include cases that don't report time_to_play
 @benchmark.Disabled('android')
 class MediaExtra(perf_benchmark.PerfBenchmark):
   """Obtains extra media metrics for key user scenarios."""
   test = media.Media
   page_set = page_sets.ToughVideoCasesExtraPageSet
 
   @classmethod
   def Name(cls):
     return 'media.tough_video_cases_extra'
@@ skipping 74 matching lines @@
 
   @classmethod
   def Name(cls):
     return 'media.mse_cases'
 
   def SetExtraBrowserOptions(self, options):
     # Needed to allow XHR requests to return stream objects.
     options.AppendExtraBrowserArgs(
         ['--enable-experimental-web-platform-features',
          '--disable-gesture-requirement-for-media-playback'])