chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java - Issue 2743763003: [Payments] Format and validate phone number by using libphonenumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

Issue 2743763003: [Payments] Format and validate phone number by using libphonenumber (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java » ('j') | chrome/browser/autofill/android/phone_number_util_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

index e6df271838bbdfb6c8e5270a61570f2670b84aa5..8d99d4a7a25edcf4e1e6fff462076cf6ca2f2cdc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

@@ -5,13 +5,13 @@

package org.chromium.chrome.browser.payments;

import android.os.Handler;

-import android.telephony.PhoneNumberUtils;

import android.util.Pair;

import org.chromium.base.Callback;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.autofill.PersonalDataManager;

import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;

+import org.chromium.chrome.browser.autofill.PhoneNumberUtil;

import org.chromium.chrome.browser.payments.ui.EditorFieldModel;

import org.chromium.chrome.browser.payments.ui.EditorFieldModel.EditorFieldValidator;

import org.chromium.chrome.browser.payments.ui.EditorModel;

@@ -305,8 +305,7 @@ public class AddressEditor extends EditorBase<AutofillAddress> {

@Override

public boolean isValid(@Nullable CharSequence value) {

return value != null

- && PhoneNumberUtils.isGlobalPhoneNumber(

- PhoneNumberUtils.stripSeparators(value.toString()));

+ && PhoneNumberUtil.getInstance().isValidNumber(value.toString());

}

@Override