chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java - Issue 2743763003: [Payments] Format and validate phone number by using libphonenumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

Issue 2743763003: [Payments] Format and validate phone number by using libphonenumber (Closed)

Patch Set: formats Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

index 284a17800c3199a0f34d76679852786724b01dec..e2d388473196e851a55ced8ed3013564c403b17a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

@@ -34,7 +34,7 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {

AutofillTestHelper helper = new AutofillTestHelper();

String billingAddressId = helper.setProfile(new AutofillProfile("", "https://example.com",

true, "Jon Doe", "Google", "340 Main St", "CA", "Los Angeles", "", "90291", "",

- "US", "310-310-6000", "jon.doe@gmail.com", "en-US"));

+ "US", "650-253-0000", "jon.doe@gmail.com", "en-US"));

helper.setCreditCard(new CreditCard("", "https://example.com", true, true, "Jon Doe",

"4111111111111111", "1111", "12", "2050", "visa", R.drawable.pr_visa,

billingAddressId, "" /* serverId */));

@@ -183,7 +183,7 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {

mReadyToEdit);

setTextInEditorAndWait(new String[] {"Bob", "Google", "1600 Amphitheatre Pkwy",

- "Mountain View", "CA", "94043", "999-999-9999"}, mEditorTextUpdate);

+ "Mountain View", "CA", "94043", "650-253-0000"}, mEditorTextUpdate);

clickInEditorAndWait(R.id.payments_edit_done_button, mReadyToEdit);

clickInCardEditorAndWait(R.id.payments_edit_done_button, mReadyToPay);

@@ -191,7 +191,7 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {

setTextInCardUnmaskDialogAndWait(R.id.card_unmask_input, "123", mReadyToUnmask);

clickCardUnmaskButtonAndWait(DialogInterface.BUTTON_POSITIVE, mDismissed);

expectResultContains(new String[] {"5454545454545454", "12", "Bob", "Google",

- "1600 Amphitheatre Pkwy", "Mountain View", "CA", "94043", "999-999-9999"});

+ "1600 Amphitheatre Pkwy", "Mountain View", "CA", "94043", "+1 650-253-0000"});

}

/** Quickly pressing on "add card" and then [X] should not crash. */