Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc

Issue 2743743003: GridLayout: Guard against layout queries while adding a view. (Closed)
Patch Set: Rebase for BUILD.gn conflict Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f0536d5db14783384537c5a52fa9bdbdac25796f
--- /dev/null
+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc
@@ -0,0 +1,30 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/bookmarks/bookmark_editor_view.h"
+
+#include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+
+// Test harness for integration tests using BookmarkEditorView.
+class BookmarkEditorViewBrowserTest : public DialogBrowserTest {
+ public:
+ BookmarkEditorViewBrowserTest() {}
+
+ // DialogBrowserTest:
+ void ShowDialog(const std::string& name) override {
+ DCHECK_EQ("all_tabs", name);
+ chrome::ShowBookmarkAllTabsDialog(browser());
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(BookmarkEditorViewBrowserTest);
+};
+
+// Shows the dialog for bookmarking all tabs. This shows a BookmarkEditorView
+// dialog, with a tree view, where a user can rename and select a parent folder.
+// Can be interactive when run with --gtest_filter=BrowserDialogTest.Invoke.
+IN_PROC_BROWSER_TEST_F(BookmarkEditorViewBrowserTest, InvokeDialog_all_tabs) {
+ RunDialog();
+}
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698