Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2743723003: Add buffering to MimeSniffingResourceHandler.

Created:
3 years, 9 months ago by Randy Smith (Not in Mondays)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add buffering to MimeSniffingResourceHandler. This allows MimeSniffingResourceHandler to be more self-contained, and removes dependencies on the kMaxBytesToSniff at several other places in the stack. It should not hurt performance because InterceptingResourceHandler no longer needs to buffer if MimeSniffingResourceHandler does so. BUG=

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : Sync'd to TOT; unit tests pass. #

Patch Set 4 : git cl format #

Patch Set 5 : Remove unused 'first_call' variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -678 lines) Patch
M content/browser/loader/intercepting_resource_handler.h View 1 2 5 chunks +9 lines, -49 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler.cc View 1 2 9 chunks +23 lines, -163 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler_unittest.cc View 1 2 19 chunks +48 lines, -81 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.h View 1 4 chunks +16 lines, -16 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.cc View 1 2 3 7 chunks +36 lines, -56 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler_unittest.cc View 1 2 3 16 chunks +189 lines, -103 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 2 3 4 8 chunks +9 lines, -98 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 2 3 3 chunks +0 lines, -92 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 2 3 3 chunks +3 lines, -11 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler_unittest.cc View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (20 generated)
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-09 20:52:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743723003/1
3 years, 9 months ago (2017-03-09 20:52:53 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-09 20:55:40 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/167815) ios-simulator on ...
3 years, 9 months ago (2017-03-09 20:55:40 UTC) #4
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-25 21:04:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743723003/40001
3 years, 9 months ago (2017-03-25 21:04:34 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-25 21:51:40 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/257871)
3 years, 9 months ago (2017-03-25 21:51:41 UTC) #8
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-26 00:29:49 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743723003/40001
3 years, 9 months ago (2017-03-26 00:29:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-26 01:09:49 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/257881)
3 years, 9 months ago (2017-03-26 01:09:50 UTC) #12
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-26 12:16:15 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743723003/60001
3 years, 9 months ago (2017-03-26 12:16:19 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-26 12:40:39 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/39768)
3 years, 9 months ago (2017-03-26 12:40:40 UTC) #16
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-26 12:42:03 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743723003/80001
3 years, 9 months ago (2017-03-26 12:42:08 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-26 13:12:28 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-26 13:12:28 UTC) #20 
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698