Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2743683002: [Tests] Disable flaky smoke test (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 # crbug.com/ 49 # crbug.com/
50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long 50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long
51 51
52 # crbug.com/696824 52 # crbug.com/696824
53 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:news:qq', # pylint: disable=line-too-long 53 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:news:qq', # pylint: disable=line-too-long
54 54
55 # crbug.com/698006 55 # crbug.com/698006
56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:drive', # pylint: disable=line-too-long 56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:drive', # pylint: disable=line-too-long
57 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:gmail', # pylint: disable=line-too-long 57 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:gmail', # pylint: disable=line-too-long
58
59 # crbug.com/699966
60 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.multitab:misc:typical24', # pylint: disable=line-too-long
58 }) 61 })
59 62
60 63
61 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 64 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
62 65
63 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 66 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
64 # 67 #
65 # This smoke test dynamically tests all system health user stories. So 68 # This smoke test dynamically tests all system health user stories. So
66 # disabling it for one failing or flaky benchmark would disable a much 69 # disabling it for one failing or flaky benchmark would disable a much
67 # wider swath of coverage than is usally intended. Instead, if a test is 70 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 # parsed during test time which happens after load_tests are called. 149 # parsed during test time which happens after load_tests are called.
147 # Since none of our system health benchmarks creates stories based on 150 # Since none of our system health benchmarks creates stories based on
148 # command line options, it should be ok to pass options=None to 151 # command line options, it should be ok to pass options=None to
149 # CreateStorySet. 152 # CreateStorySet.
150 for story_to_smoke_test in ( 153 for story_to_smoke_test in (
151 benchmark_class().CreateStorySet(options=None).stories): 154 benchmark_class().CreateStorySet(options=None).stories):
152 suite.addTest( 155 suite.addTest(
153 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 156 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
154 157
155 return suite 158 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698