Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h

Issue 2743663003: Un-DCHECK-guard ThreadRestrictionVerifier for strings. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ThreadRestrictionVerifier_h 31 #ifndef ThreadRestrictionVerifier_h
32 #define ThreadRestrictionVerifier_h 32 #define ThreadRestrictionVerifier_h
33 33
34 #include "wtf/Assertions.h" 34 #include "wtf/Assertions.h"
35 35
36 #if DCHECK_IS_ON() 36 // TODO(meade): Revert this by 17 Mar 17.
37 // This is for investigating crbug.com/694520
38 // #if DCHECK_IS_ON()
37 39
38 #include "wtf/Threading.h" 40 #include "wtf/Threading.h"
39 41
40 namespace WTF { 42 namespace WTF {
41 43
42 // Verifies that a class is used in a way that respects its lack of 44 // Verifies that a class is used in a way that respects its lack of
43 // thread-safety. The default mode is to verify that the object will only be 45 // thread-safety. The default mode is to verify that the object will only be
44 // used on a single thread. The thread gets captured when setShared(true) is 46 // used on a single thread. The thread gets captured when setShared(true) is
45 // called. The mode may be changed by calling useMutexMode (or 47 // called. The mode may be changed by calling useMutexMode (or
46 // turnOffVerification). 48 // turnOffVerification).
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 m_owningThread = currentThread(); 99 m_owningThread = currentThread();
98 } 100 }
99 101
100 bool m_shared; 102 bool m_shared;
101 103
102 ThreadIdentifier m_owningThread; 104 ThreadIdentifier m_owningThread;
103 }; 105 };
104 106
105 } // namespace WTF 107 } // namespace WTF
106 108
107 #endif // DCHECK_IS_ON() 109 // #endif // DCHECK_IS_ON()
108 #endif // ThreadRestrictionVerifier_h 110 #endif // ThreadRestrictionVerifier_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698