third_party/WebKit/Source/web/WebFrame.cpp - Issue 2743653002: Make context initialization order deterministic in WebFrame::swap().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2743653002: Make context initialization order deterministic in WebFrame::swap(). (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 59df86f0c71e8dce1b85eb387ee2e9d37f4e6b41..eb21ece7a87e62c54cfe3c99da70c19cdfe9d072 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -74,7 +74,7 @@ bool WebFrame::swap(WebFrame* frame) {

FrameOwner* owner = oldFrame->owner();

v8::HandleScope handleScope(v8::Isolate::GetCurrent());

- HashMap<DOMWrapperWorld*, v8::Local<v8::Object>> globals;

+ WindowProxyManagerBase::GlobalsVector globals;

oldFrame->getWindowProxyManager()->clearForNavigation();

oldFrame->getWindowProxyManager()->releaseGlobals(globals);