Make context initialization order deterministic in WebFrame::swap().

third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/WindowProxyManager.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 
 namespace blink {
 
@@ skipping 39 matching lines @@
   for (auto& entry : m_isolatedWorlds)
     entry.value->clearForClose();
 }
 
 void WindowProxyManagerBase::clearForNavigation() {
   m_windowProxy->clearForNavigation();
   for (auto& entry : m_isolatedWorlds)
     entry.value->clearForNavigation();
 }
 
-void WindowProxyManagerBase::releaseGlobals(
-    HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>& map) {
-  map.insert(&m_windowProxy->world(), m_windowProxy->releaseGlobal());
-  for (auto& entry : m_isolatedWorlds)
-    map.insert(&entry.value->world(),
-               windowProxy(entry.value->world())->releaseGlobal());
+void WindowProxyManagerBase::releaseGlobals(GlobalsVector& globals) {
+  globals.reserveInitialCapacity(1 + m_isolatedWorlds.size());
+  globals.emplace_back(&m_windowProxy->world(), m_windowProxy->releaseGlobal());
+  for (auto& entry : m_isolatedWorlds) {
+    globals.emplace_back(&entry.value->world(),
+                         windowProxy(entry.value->world())->releaseGlobal());
+  }
 }
 
-void WindowProxyManagerBase::setGlobals(
-    const HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>& map) {
-  for (auto& entry : map)
-    windowProxy(*entry.key)->setGlobal(entry.value);
+void WindowProxyManagerBase::setGlobals(const GlobalsVector& globals) {
+  for (const auto& entry : globals)
+    windowProxy(*entry.first)->setGlobal(entry.second);
 }
 
 WindowProxyManagerBase::WindowProxyManagerBase(Frame& frame)
     : m_isolate(v8::Isolate::GetCurrent()),
       m_frame(&frame),
       m_windowProxy(createWindowProxyForFrame(m_isolate,
                                               frame,
                                               &DOMWrapperWorld::mainWorld())) {}
 
 void LocalWindowProxyManager::updateSecurityOrigin(
     SecurityOrigin* securityOrigin) {
   static_cast<LocalWindowProxy*>(mainWorldProxy())
       ->updateSecurityOrigin(securityOrigin);
   for (auto& entry : isolatedWorlds()) {
     auto* isolatedWindowProxy =
         static_cast<LocalWindowProxy*>(entry.value.get());
     SecurityOrigin* isolatedSecurityOrigin =
         isolatedWindowProxy->world().isolatedWorldSecurityOrigin();
     isolatedWindowProxy->updateSecurityOrigin(isolatedSecurityOrigin);
   }
 }
 
 }  // namespace blink