[fasta] Add and correct more offsets

[fasta] Add and correct more offsets

E.g. on

StringConcatenation
ListLiteral
MapLiteral
Throw
VariableDeclaration
break
continue
++i
i++

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/f8588ba47c9e52cca69f37df974a82697831ac60

[jensj, 2017-03-09 11:29:46]

jensj@google.com changed reviewers:
+ ahe@google.com

[jensj, 2017-03-09 11:29:47]

Status of service tests:


With source:

===
=== 35 tests failed
===

[02:47 | 100% | +   96 | -   35]


Without source:

===
=== 46 tests failed
===

[02:45 | 100% | +   85 | -   46]

[jensj, 2017-03-09 11:50:44]

For reference, this is the status of service tests with what's on master (i.e.
without this CL):

With source:

===
=== 44 tests failed
===

[02:46 | 100% | +   86 | -   44]


Without source:

===
=== 49 tests failed
===

[02:43 | 100% | +   81 | -   49]


(I don't know why there seems to be one more test with this CL than without this
CL though)

[ahe, 2017-03-09 12:19:37]

lgtm

@paulberry: you may see some conflicts from this CL.

https://codereview.chromium.org/2743633003/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/scanner.dart (right):

https://codereview.chromium.org/2743633003/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/scanner.dart:39: listener.endLiteralString(0,
token);
I recommend making sure that you have tested this with some html tests running
in a browser (let me know if you need help finding the right test.py options).

Also, make sure to test:

-cdart2js -rd8 --host-checked dart2js_native

https://codereview.chromium.org/2743633003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart (right):

https://codereview.chromium.org/2743633003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart:712: charOffset +
variable.name.length);
variable.name might be null.

[ahe, 2017-03-09 12:33:33]

I think this should do for testing html:

./tools/test.py -mrelase -cdart2js -rchrome html

[ahe, 2017-03-09 12:34:13]

On 2017/03/09 12:33:33, ahe wrote:
> I think this should do for testing html:
> 
> ./tools/test.py -mrelase -cdart2js -rchrome html

This option is important: --dart2js-batch

[jensj, 2017-03-09 12:55:25]

Running
./tools/test.py --dart2js-batch -mrelease -cdart2js -rchrome html

gives me 22 failures both with and without this CL --- all expected failures
that are passing, and all in html/webgl_extensions_test/.* --- I'm guessing
that's the build bots not being able to do webgl stuff?

https://codereview.chromium.org/2743633003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart (right):

https://codereview.chromium.org/2743633003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart:712: charOffset +
variable.name.length);
On 2017/03/09 12:19:37, ahe wrote:
> variable.name might be null.

Fixed.

[ahe, 2017-03-09 13:06:15]

On 2017/03/09 12:55:25, jensj wrote:
> Running
> ./tools/test.py --dart2js-batch -mrelease -cdart2js -rchrome html
> 
> gives me 22 failures both with and without this CL --- all expected failures
> that are passing, and all in html/webgl_extensions_test/.* --- I'm guessing
> that's the build bots not being able to do webgl stuff?

Running browser tests locally is notoriously problematic. But as you discovered,
checking before and after is a way to work around that.

I think you're covered.

[jensj, 2017-03-10 07:17:22]

Description was changed from

==========
[fasta] Add and correct more offsets

E.g. on

StringConcatenation
ListLiteral
MapLiteral
Throw
VariableDeclaration
break
continue
++i
i++
==========

to

==========
[fasta] Add and correct more offsets

E.g. on

StringConcatenation
ListLiteral
MapLiteral
Throw
VariableDeclaration
break
continue
++i
i++

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f8588ba47c9e52cca69f37df974a82697831ac60
==========

[jensj, 2017-03-10 07:17:23]

Committed patchset #3 (id:40001) manually as
f8588ba47c9e52cca69f37df974a82697831ac60 (presubmit successful).