src/debug/debug-evaluate.cc - Issue 2743613002: [debugger] remove outdated TODO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 2743613002: [debugger] remove outdated TODO. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index eca0b360d976df87a017388467bbdd55139ebadb..bb3e85baafdb1ad010d72de47abb0b650c50fd46 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -210,7 +210,6 @@ DebugEvaluate::ContextBuilder::ContextBuilder(Isolate* isolate,

void DebugEvaluate::ContextBuilder::UpdateValues() {

- // TODO(yangguo): remove updating values.

for (int i = 0; i < context_chain_.length(); i++) {

ContextChainElement element = context_chain_[i];

if (!element.materialized_object.is_null()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »