Reflect device status in geolocation permissions.request calls.

chrome/browser/permissions/permission_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_manager.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/callback.h"
@@ skipping 421 matching lines @@
     return;
 
   context->ResetPermission(requesting_origin.GetOrigin(),
                            embedding_origin.GetOrigin());
 }
 
 PermissionStatus PermissionManager::GetPermissionStatus(
     PermissionType permission,
     const GURL& requesting_origin,
     const GURL& embedding_origin) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

[raymes, 2017/03/10 02:53:31]

I think this may not work for MIDI anymore (need to add the constant permission
check). It's unfortunate that no tests picked up on this.

I think it would be better to call GetPermissionStatusHelper rather than
checking the context.

[benwells, 2017/03/10 04:19:19]

As discussed this should all be OK as is.

-  return ContentSettingToPermissionStatus(
+  PermissionResult result =
       GetPermissionStatus(PermissionTypeToContentSetting(permission),
-                          requesting_origin, embedding_origin)
-          .content_setting);
+                          requesting_origin, embedding_origin);
+
+  // TODO(benwells): split this into two functions, GetPermissionStatus and
+  // GetPermissionStatusForPermissionsAPI.
+  PermissionContextBase* context =
+      GetPermissionContext(PermissionTypeToContentSetting(permission));
+  if (context) {
+    result = context->UpdatePermissionStatusWithDeviceStatus(
+        result, requesting_origin, embedding_origin);
+  }
+
+  return ContentSettingToPermissionStatus(result.content_setting);
 }
 
 int PermissionManager::SubscribePermissionStatusChange(
     PermissionType permission,
     const GURL& requesting_origin,
     const GURL& embedding_origin,
     const base::Callback<void(PermissionStatus)>& callback) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (subscriptions_.IsEmpty())
     HostContentSettingsMapFactory::GetForProfile(profile_)->AddObserver(this);
@@ skipping 81 matching lines @@
   }
   PermissionContextBase* context = GetPermissionContext(permission);
   PermissionResult result = context->GetPermissionStatus(
       nullptr /* render_frame_host */, requesting_origin.GetOrigin(),
       embedding_origin.GetOrigin());
   DCHECK(result.content_setting == CONTENT_SETTING_ALLOW ||
          result.content_setting == CONTENT_SETTING_ASK ||
          result.content_setting == CONTENT_SETTING_BLOCK);
   return result;
 }