Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2743573004: DevTools: move the filtered items caption into the toolbar. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 084a5c4f2233bcffa620321a92c6c007803b12cb..6c7014df126c7c0ae4d4b72e0b9e30017ba82389 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -60,10 +60,11 @@ Console.ConsoleView = class extends UI.VBox {
this._executionContextComboBox.setMaxWidth(80);
this._consoleContextSelector = new Console.ConsoleContextSelector(this._executionContextComboBox.selectElement());
+ this._filterStatusText = new UI.ToolbarText();
+ this._filterStatusText.element.classList.add('dimmed');
this._showSettingsPaneSetting = Common.settings.createSetting('consoleShowSettingsToolbar', false);
this._showSettingsPaneButton = new UI.ToolbarSettingToggle(
this._showSettingsPaneSetting, 'largeicon-settings-gear', Common.UIString('Console settings'));
-
this._progressToolbarItem = new UI.ToolbarItem(createElement('div'));
var toolbar = new UI.Toolbar('', this._contentsElement);
@@ -76,7 +77,7 @@ Console.ConsoleView = class extends UI.VBox {
toolbar.appendToolbarItem(this._filter._levelComboBox);
toolbar.appendToolbarItem(this._progressToolbarItem);
toolbar.appendSpacer();
- toolbar.appendText('');
+ toolbar.appendToolbarItem(this._filterStatusText);
toolbar.appendSeparator();
toolbar.appendToolbarItem(this._showSettingsPaneButton);
@@ -121,11 +122,6 @@ Console.ConsoleView = class extends UI.VBox {
this._viewportThrottler = new Common.Throttler(50);
- this._filterStatusMessageElement = createElementWithClass('div', 'console-message');
- this._messagesElement.insertBefore(this._filterStatusMessageElement, this._messagesElement.firstChild);
- this._filterStatusTextElement = this._filterStatusMessageElement.createChild('span', 'console-info');
- this._filterStatusMessageElement.createTextChild(' ');
-
this._topGroup = Console.ConsoleGroup.createTopGroup();
this._currentGroup = this._topGroup;
@@ -435,11 +431,10 @@ Console.ConsoleView = class extends UI.VBox {
}
_updateFilterStatus() {
- this._filterStatusTextElement.removeChildren();
- this._filterStatusTextElement.createTextChild(Common.UIString(
- this._hiddenByFilterCount === 1 ? '1 message is hidden by filters.' :
- this._hiddenByFilterCount + ' messages are hidden by filters.'));
- this._filterStatusMessageElement.style.display = this._hiddenByFilterCount ? '' : 'none';
+ this._filterStatusText.setText(Common.UIString(
+ this._hiddenByFilterCount === 1 ? '1 item hidden by filters' :
+ this._hiddenByFilterCount + ' items hidden by filters'));
+ this._filterStatusText.setVisible(!!this._hiddenByFilterCount);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698