Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2743423009: Run dartfmt on remaining unformated pkg packages (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
vsm, Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Run dartfmt on remaining unformated pkg packages #

Total comments: 2

Patch Set 3 : Run dartfmt on remaining unformated pkg packages #

Patch Set 4 : Run dartfmt on remaining unformated pkg packages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -408 lines) Patch
M pkg/async_helper/lib/async_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/lookup_map/lib/lookup_map.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/lookup_map/test/lookup_map_test.dart View 4 chunks +20 lines, -10 lines 0 comments Download
M pkg/testing/lib/src/analyze.dart View 5 chunks +17 lines, -23 lines 0 comments Download
M pkg/testing/lib/src/chain.dart View 6 chunks +31 lines, -49 lines 0 comments Download
M pkg/testing/lib/src/discover.dart View 3 chunks +7 lines, -18 lines 0 comments Download
M pkg/testing/lib/src/error_handling.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/testing/lib/src/expectation.dart View 2 chunks +27 lines, -21 lines 0 comments Download
M pkg/testing/lib/src/log.dart View 4 chunks +10 lines, -15 lines 0 comments Download
M pkg/testing/lib/src/run.dart View 5 chunks +29 lines, -49 lines 0 comments Download
M pkg/testing/lib/src/run_tests.dart View 4 chunks +63 lines, -75 lines 0 comments Download
M pkg/testing/lib/src/stdio_process.dart View 2 chunks +12 lines, -24 lines 0 comments Download
M pkg/testing/lib/src/suite.dart View 2 chunks +6 lines, -8 lines 0 comments Download
M pkg/testing/lib/src/test_dart.dart View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
M pkg/testing/lib/src/test_dart/status_file_parser.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/testing/lib/src/test_description.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/testing/lib/src/test_root.dart View 2 chunks +8 lines, -17 lines 0 comments Download
M pkg/testing/lib/src/zone_helper.dart View 3 chunks +10 lines, -24 lines 0 comments Download
M pkg/testing/lib/testing.dart View 1 chunk +5 lines, -15 lines 0 comments Download
M pkg/typed_mock/lib/typed_mock.dart View 16 chunks +0 lines, -17 lines 0 comments Download
M pkg/typed_mock/test/typed_mock_test.dart View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jacob
3 years, 9 months ago (2017-03-16 04:00:10 UTC) #2
Jacob
3 years, 9 months ago (2017-03-22 00:32:26 UTC) #4
Emily Fortuna
https://codereview.chromium.org/2743423009/diff/20001/pkg/analyzer_plugin/lib/protocol/protocol_constants.dart File pkg/analyzer_plugin/lib/protocol/protocol_constants.dart (right): https://codereview.chromium.org/2743423009/diff/20001/pkg/analyzer_plugin/lib/protocol/protocol_constants.dart#newcode29 pkg/analyzer_plugin/lib/protocol/protocol_constants.dart:29: const String ANALYSIS_REQUEST_HANDLE_WATCH_EVENTS = 'analysis.handleWatchEvents'; these make the line ...
3 years, 9 months ago (2017-03-22 00:59:07 UTC) #5
Jacob
ptal
3 years, 9 months ago (2017-03-22 01:08:49 UTC) #6
Emily Fortuna
lgtm
3 years, 9 months ago (2017-03-22 01:14:34 UTC) #7
Jacob
3 years, 9 months ago (2017-03-22 01:21:38 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
de54e1836937d52db3121c00343b198771b31acd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698