Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/ui/views/page_info/permission_selector_row.cc

Issue 2743423004: Permissions: Show the reason for permission decisions made on the user's behalf. (Closed)
Patch Set: Review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/page_info/page_info_ui.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/page_info/permission_selector_row.cc
diff --git a/chrome/browser/ui/views/page_info/permission_selector_row.cc b/chrome/browser/ui/views/page_info/permission_selector_row.cc
index ac79ebc88ffa57a1b3482b3f99ebb98c1b888e19..5f56e1e8233141195c25e16beeb57860e206e9e4 100644
--- a/chrome/browser/ui/views/page_info/permission_selector_row.cc
+++ b/chrome/browser/ui/views/page_info/permission_selector_row.cc
@@ -266,6 +266,22 @@ PermissionSelectorRow::PermissionSelectorRow(
InitializeComboboxView(layout, permission);
else
InitializeMenuButtonView(layout, permission);
+
+ // Show the permission decision reason, if it was not the user.
+ base::string16 reason =
+ PageInfoUI::PermissionDecisionReasonToUIString(profile, permission, url);
+ if (!reason.empty()) {
+ layout->StartRow(1, 1);
+ layout->SkipColumns(1);
+ views::Label* permission_decision_reason = new views::Label(reason);
+ permission_decision_reason->SetEnabledColor(
+ PageInfoUI::GetPermissionDecisionTextColor());
+ // Long labels should span the remaining width of the row.
+ views::ColumnSet* column_set = layout->GetColumnSet(1);
+ DCHECK(column_set);
+ layout->AddView(permission_decision_reason, column_set->num_columns() - 2,
+ 1, views::GridLayout::LEADING, views::GridLayout::CENTER);
+ }
}
void PermissionSelectorRow::AddObserver(
« no previous file with comments | « chrome/browser/ui/page_info/page_info_ui.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698