Permissions: Show the reason for permission decisions made on the user's behalf.

chrome/browser/ui/page_info/website_settings_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/page_info/website_settings_ui.h"
 
 #include "base/macros.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/permissions/permission_manager.h"
+#include "chrome/browser/permissions/permission_result.h"
+#include "chrome/browser/permissions/permission_util.h"
 #include "chrome/browser/plugins/plugin_utils.h"
 #include "chrome/browser/plugins/plugins_field_trial.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/strings/grit/components_strings.h"
 #include "ppapi/features/features.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"

[dominickn, 2017/03/26 23:46:24]

#include "url/gurl.h"

[Patti Lor, 2017/03/27 05:52:40]

Done.

 
 namespace {
 
 const int kInvalidResourceID = -1;
 
 // The resource IDs for the strings that are displayed on the permissions
-// button if the permission setting is managed by policy.
-const int kPermissionButtonTextIDPolicyManaged[] = {
-    kInvalidResourceID,
-    IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_POLICY,
-    IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_POLICY,
-    IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_POLICY,
-    kInvalidResourceID,
-    kInvalidResourceID};
-static_assert(arraysize(kPermissionButtonTextIDPolicyManaged) ==
-              CONTENT_SETTING_NUM_SETTINGS,
-              "kPermissionButtonTextIDPolicyManaged array size is incorrect");
-
-// The resource IDs for the strings that are displayed on the permissions
-// button if the permission setting is managed by an extension.
-const int kPermissionButtonTextIDExtensionManaged[] = {
-    kInvalidResourceID,
-    IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_EXTENSION,
-    IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_EXTENSION,
-    kInvalidResourceID,
-    kInvalidResourceID,
-    kInvalidResourceID};
-static_assert(arraysize(kPermissionButtonTextIDExtensionManaged) ==
-              CONTENT_SETTING_NUM_SETTINGS,
-              "kPermissionButtonTextIDExtensionManaged array size is "
-              "incorrect");
-
-// The resource IDs for the strings that are displayed on the permissions
 // button if the permission setting is managed by the user.
 const int kPermissionButtonTextIDUserManaged[] = {
     kInvalidResourceID,
     IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_USER,
     IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER,
     IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_USER,
     kInvalidResourceID,
     IDS_WEBSITE_SETTINGS_BUTTON_TEXT_DETECT_IMPORTANT_CONTENT_BY_USER};
 static_assert(arraysize(kPermissionButtonTextIDUserManaged) ==
               CONTENT_SETTING_NUM_SETTINGS,
@@ skipping 191 matching lines @@
   // is removed, just migrate the actual content setting to ASK.
   if (PluginUtils::ShouldPreferHtmlOverPlugins(host_content_settings_map) &&
       effective_setting == CONTENT_SETTING_DETECT_IMPORTANT_CONTENT) {
     effective_setting = CONTENT_SETTING_ASK;
   }
 #endif
 
   const int* button_text_ids = NULL;
   switch (source) {
     case content_settings::SETTING_SOURCE_USER:
-      if (setting == CONTENT_SETTING_DEFAULT)
+      if (setting == CONTENT_SETTING_DEFAULT) {
         button_text_ids = kPermissionButtonTextIDDefaultSetting;
-      else
-        button_text_ids = kPermissionButtonTextIDUserManaged;
-      break;
+        break;
+      }
+    // Fallthrough.
     case content_settings::SETTING_SOURCE_POLICY:
-      button_text_ids = kPermissionButtonTextIDPolicyManaged;
-      break;
     case content_settings::SETTING_SOURCE_EXTENSION:
-      button_text_ids = kPermissionButtonTextIDExtensionManaged;
+      button_text_ids = kPermissionButtonTextIDUserManaged;
       break;
     case content_settings::SETTING_SOURCE_WHITELIST:
     case content_settings::SETTING_SOURCE_NONE:
     default:
       NOTREACHED();
       return base::string16();
   }
   int button_text_id = button_text_ids[effective_setting];
   DCHECK_NE(button_text_id, kInvalidResourceID);
   return l10n_util::GetStringUTF16(button_text_id);
 }
 
 // static
+base::string16 WebsiteSettingsUI::PermissionDecisionReasonToString(
+    Profile* profile,
+    const WebsiteSettingsUI::PermissionInfo& permission,
+    const GURL& url) {
+  int message_id = kInvalidResourceID;
+  switch (permission.source) {
+    case content_settings::SettingSource::SETTING_SOURCE_POLICY:
+      message_id = IDS_WEBSITE_SETTINGS_PERMISSION_SET_BY_POLICY;
+      break;
+    case content_settings::SettingSource::SETTING_SOURCE_EXTENSION:
+      message_id = IDS_WEBSITE_SETTINGS_PERMISSION_SET_BY_EXTENSION;
+      break;
+    default:
+      break;
+  }
+
+  if (permission.setting == CONTENT_SETTING_BLOCK &&
+      PermissionUtil::IsPermission(permission.type)) {
+    PermissionResult permission_result =
+        PermissionManager::Get(profile)->GetPermissionStatus(permission.type,
+                                                             url, url);
+    switch (permission_result.source) {
+      case PermissionStatusSource::MULTIPLE_DISMISSALS:
+      case PermissionStatusSource::SAFE_BROWSING_BLACKLIST:
+        message_id = IDS_WEBSITE_SETTINGS_PERMISSION_AUTOMATICALLY_BLOCKED;
+        break;
+      default:
+        break;
+    }
+  }
+
+  if (message_id != kInvalidResourceID)

[dominickn, 2017/03/26 23:46:24]

Minor nit: I would flip the conditional to make it

if (message_id == kInvalidResourceID)
  return base::string16()

[Patti Lor, 2017/03/27 05:52:40]

Done.

+    return l10n_util::GetStringUTF16(message_id);
+  return base::string16();
+}
+
+// static
 int WebsiteSettingsUI::GetPermissionIconID(ContentSettingsType type,
                                            ContentSetting setting) {
   bool use_blocked = (setting == CONTENT_SETTING_BLOCK);
   for (const PermissionsUIInfo& info : kPermissionsUIInfo) {
     if (info.type == type)
       return use_blocked ? info.blocked_icon_id : info.allowed_icon_id;
   }
   NOTREACHED();
   return IDR_INFO;
 }
@@ skipping 90 matching lines @@
   }
   return resource_id;
 }
 
 // static
 const gfx::Image& WebsiteSettingsUI::GetConnectionIcon(
     WebsiteSettings::SiteConnectionStatus status) {
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   return rb.GetNativeImageNamed(GetConnectionIconID(status));
 }