Permissions: Show the reason for permission decisions made on the user's behalf.

chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.h"
 
 #include <stddef.h>
 
 #include "base/i18n/rtl.h"
 #include "base/macros.h"
@@ skipping 45 matching lines @@
 namespace {
 
 // Indices of the menu items in the permission menu.
 enum PermissionMenuIndices {
   kMenuIndexContentSettingAllow = 0,
   kMenuIndexContentSettingBlock,
   kMenuIndexContentSettingDefault
 };
 
 const ContentSettingsType kTestPermissionTypes[] = {
-  CONTENT_SETTINGS_TYPE_IMAGES,
-  CONTENT_SETTINGS_TYPE_JAVASCRIPT,
-  CONTENT_SETTINGS_TYPE_PLUGINS,
-  CONTENT_SETTINGS_TYPE_POPUPS,
-  CONTENT_SETTINGS_TYPE_GEOLOCATION,
-  CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
-  CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC
-};
+    CONTENT_SETTINGS_TYPE_IMAGES,
+    CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
+    CONTENT_SETTINGS_TYPE_JAVASCRIPT,
+    CONTENT_SETTINGS_TYPE_PLUGINS,
+    CONTENT_SETTINGS_TYPE_POPUPS,
+    CONTENT_SETTINGS_TYPE_GEOLOCATION,
+    CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+    CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC};
 
 const ContentSetting kTestSettings[] = {
-  CONTENT_SETTING_DEFAULT,
-  CONTENT_SETTING_DEFAULT,
-  CONTENT_SETTING_ALLOW,
-  CONTENT_SETTING_BLOCK,
-  CONTENT_SETTING_ALLOW,
-  CONTENT_SETTING_BLOCK,
-  CONTENT_SETTING_BLOCK
-};
+    CONTENT_SETTING_DEFAULT, CONTENT_SETTING_DEFAULT, CONTENT_SETTING_DEFAULT,
+    CONTENT_SETTING_ALLOW,   CONTENT_SETTING_BLOCK,   CONTENT_SETTING_ALLOW,
+    CONTENT_SETTING_BLOCK,   CONTENT_SETTING_BLOCK};
 
 const ContentSetting kTestDefaultSettings[] = {
-  CONTENT_SETTING_BLOCK,
-  CONTENT_SETTING_ASK
-};
+    CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK, CONTENT_SETTING_ASK};
 
 const content_settings::SettingSource kTestSettingSources[] = {
-  content_settings::SETTING_SOURCE_USER,
-  content_settings::SETTING_SOURCE_USER,
-  content_settings::SETTING_SOURCE_USER,
-  content_settings::SETTING_SOURCE_USER,
-  content_settings::SETTING_SOURCE_POLICY,
-  content_settings::SETTING_SOURCE_POLICY,
-  content_settings::SETTING_SOURCE_EXTENSION
-};
+    content_settings::SETTING_SOURCE_USER,
+    content_settings::SETTING_SOURCE_USER,
+    content_settings::SETTING_SOURCE_USER,
+    content_settings::SETTING_SOURCE_USER,
+    content_settings::SETTING_SOURCE_USER,
+    content_settings::SETTING_SOURCE_POLICY,
+    content_settings::SETTING_SOURCE_POLICY,
+    content_settings::SETTING_SOURCE_EXTENSION};
 
 class WebsiteSettingsBubbleControllerTest : public CocoaTest {
  public:
   WebsiteSettingsBubbleControllerTest() {
     controller_ = nil;
   }
 
   void TearDown() override {
     [controller_ close];
     CocoaTest::TearDown();
@@ skipping 65 matching lines @@
         [views addObject:view];
     }
     return views;
   }
 
   // Sets up the dialog with some test permission settings.
   void SetTestPermissions() {
     // Create a list of 5 different permissions, corresponding to all the
     // possible settings:
     // - [allow, block, ask] by default
-    // - [block, allow] * [by user, by policy, by extension]
+    // - [block, allow] by user
     PermissionInfoList permission_info_list;
     WebsiteSettingsUI::PermissionInfo info;
     for (size_t i = 0; i < arraysize(kTestPermissionTypes); ++i) {
       info.type = kTestPermissionTypes[i];
       info.setting = kTestSettings[i];
       if (info.setting == CONTENT_SETTING_DEFAULT)
         info.default_setting = kTestDefaultSettings[i];
       info.source = kTestSettingSources[i];
       info.is_incognito = false;
       permission_info_list.push_back(info);
     }
     ChosenObjectInfoList chosen_object_info_list;
     bridge_->SetPermissionInfo(permission_info_list,
                                std::move(chosen_object_info_list));
   }
 
+  int NumSettingsNotSetByUser() const {
+    int num_non_user_settings = 0;
+    for (size_t i = 0; i < arraysize(kTestSettingSources); ++i) {
+      num_non_user_settings +=
+          (kTestSettingSources[i] != content_settings::SETTING_SOURCE_USER) ? 1
+                                                                            : 0;
+    }
+    return num_non_user_settings;
+  }
+
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   content::TestWebContentsFactory web_contents_factory_;
 
   WebsiteSettingsBubbleControllerForTesting* controller_;  // Weak, owns self.
   NSWindow* window_;  // Weak, owned by controller.
 };
 
 TEST_F(WebsiteSettingsBubbleControllerTest, ConnectionHelpButton) {
   WebsiteSettingsUI::IdentityInfo info;
@@ skipping 36 matching lines @@
   // when we set an identity with `show_ssl_decision_revoke_button == false`
   // again.
 }
 
 TEST_F(WebsiteSettingsBubbleControllerTest, SetPermissionInfo) {
   CreateBubble();
   SetTestPermissions();
 
   // There should be three subviews per permission.
   NSArray* subviews = [[controller_ permissionsView] subviews];
-  EXPECT_EQ(arraysize(kTestPermissionTypes) * 3 , [subviews count]);
+  EXPECT_EQ(arraysize(kTestPermissionTypes) * 3,
+            [subviews count] - NumSettingsNotSetByUser());
 
-  // Ensure that there is a distinct label for each permission.
-  NSMutableSet* labels = [NSMutableSet set];
+  // Ensure that there is a label for each permission.
+  NSMutableArray* permission_labels = [NSMutableArray array];
   for (NSView* view in subviews) {
     if ([view isKindOfClass:[NSTextField class]])
-      [labels addObject:[static_cast<NSTextField*>(view) stringValue]];
+      [permission_labels
+          addObject:[static_cast<NSTextField*>(view) stringValue]];
   }
-  EXPECT_EQ(arraysize(kTestPermissionTypes), [labels count]);
+  EXPECT_EQ(arraysize(kTestPermissionTypes),
+            [permission_labels count] - NumSettingsNotSetByUser());
 
   // Ensure that the button labels are distinct, and look for the correct
   // number of disabled buttons.
   int disabled_count = 0;
-  [labels removeAllObjects];
+  NSMutableSet* button_labels = [NSMutableSet set];
   for (NSView* view in subviews) {
     if ([view isKindOfClass:[NSPopUpButton class]]) {
       NSPopUpButton* button = static_cast<NSPopUpButton*>(view);
-      [labels addObject:[[button selectedCell] title]];
+      [button_labels addObject:[[button selectedCell] title]];
 
       if (![button isEnabled])
         ++disabled_count;
     }
   }
-  EXPECT_EQ(arraysize(kTestPermissionTypes), [labels count]);
+  EXPECT_EQ(5UL, [button_labels count]);
 
-  // 3 of the buttons should be disabled -- the ones that have a setting source
-  // of SETTING_SOURCE_POLICY or SETTING_SOURCE_EXTENSION.
-  EXPECT_EQ(3, disabled_count);
+  // All non-user set settings should have disabled buttons (i.e., the ones with
+  // a setting source of SETTING_SOURCE_POLICY or SETTING_SOURCE_EXTENSION).
+  EXPECT_EQ(NumSettingsNotSetByUser(), disabled_count);
 }
 

[dominickn, 2017/03/26 23:46:24]

Should you add a test for the embargoed permissions here to ensure they have
enabled buttons?

[Patti Lor, 2017/03/27 05:52:40]

I think it's possible, but since we can't tell if something is embargoed from
PermissionInfo alone, I would have to set up a way to manually set the embargo
status from this test, which might be a bit of work. Do you think it's worth
looking into / it makes sense in this file?

 TEST_F(WebsiteSettingsBubbleControllerTest, WindowWidth) {
   const CGFloat kBigEnoughBubbleWidth = 310;
   // Creating a window that should fit everything.
   CreateBubbleWithWidth(kBigEnoughBubbleWidth);
   SetTestPermissions();
 
   CGFloat window_width = NSWidth([[controller_ window] frame]);
 
   // Check the window was made bigger to fit the content.
   EXPECT_EQ(kBigEnoughBubbleWidth, window_width);
@@ skipping 18 matching lines @@
       }
       if ([view isKindOfClass:[NSPopUpButton class]]) {
         NSPopUpButton* button = static_cast<NSPopUpButton*>(view);
         EXPECT_LT(NSMaxX([button frame]), window_width);
       }
     }
   }
 }
 
 }  // namespace