Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: components/translate/core/browser/translate_manager.cc

Issue 2743373003: Revert "Remove TranslateRankerEnforcement from fieldtrials."
Patch Set: Test: turn off explicitly ShowTranslateUI to benchmark TTFCP timings. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_manager.h" 5 #include "components/translate/core/browser/translate_manager.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 TranslateBrowserMetrics::ReportInitiationStatus( 316 TranslateBrowserMetrics::ReportInitiationStatus(
317 TranslateBrowserMetrics::INITIATION_STATUS_ABORTED_BY_RANKER); 317 TranslateBrowserMetrics::INITIATION_STATUS_ABORTED_BY_RANKER);
318 RecordTranslateEvent(metrics::TranslateEventProto::DISABLED_BY_RANKER); 318 RecordTranslateEvent(metrics::TranslateEventProto::DISABLED_BY_RANKER);
319 return; 319 return;
320 } 320 }
321 } 321 }
322 322
323 TranslateBrowserMetrics::ReportInitiationStatus( 323 TranslateBrowserMetrics::ReportInitiationStatus(
324 TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR); 324 TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR);
325 325
326 return;
326 // Prompts the user if they want the page translated. 327 // Prompts the user if they want the page translated.
327 translate_client_->ShowTranslateUI(translate::TRANSLATE_STEP_BEFORE_TRANSLATE, 328 // translate_client_->ShowTranslateUI(translate::TRANSLATE_STEP_BEFORE_TRANSLA TE,
328 language_code, 329 // language_code,
329 target_lang, 330 // target_lang,
330 TranslateErrors::NONE, 331 // TranslateErrors::NONE,
331 false); 332 // false);
332 } 333 }
333 334
334 bool TranslateManager::LanguageInULP(const std::string& language) const { 335 bool TranslateManager::LanguageInULP(const std::string& language) const {
335 if (!base::FeatureList::IsEnabled(kTranslateLanguageByULP)) 336 if (!base::FeatureList::IsEnabled(kTranslateLanguageByULP))
336 return false; 337 return false;
337 std::map<std::string, std::string> params; 338 std::map<std::string, std::string> params;
338 variations::GetVariationParamsByFeature(translate::kTranslateLanguageByULP, 339 variations::GetVariationParamsByFeature(translate::kTranslateLanguageByULP,
339 &params); 340 &params);
340 // Check the language & probability on the reading list. 341 // Check the language & probability on the reading list.
341 TranslatePrefs::LanguageAndProbabilityList reading; 342 TranslatePrefs::LanguageAndProbabilityList reading;
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 void TranslateManager::RecordTranslateEvent(int event_type) { 602 void TranslateManager::RecordTranslateEvent(int event_type) {
602 DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type)); 603 DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
603 translate_event_->set_event_type( 604 translate_event_->set_event_type(
604 static_cast<metrics::TranslateEventProto::EventType>(event_type)); 605 static_cast<metrics::TranslateEventProto::EventType>(event_type));
605 translate_event_->set_event_timestamp_sec( 606 translate_event_->set_event_timestamp_sec(
606 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds()); 607 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
607 TranslateRanker::GetInstance()->RecordTranslateEvent(*translate_event_); 608 TranslateRanker::GetInstance()->RecordTranslateEvent(*translate_event_);
608 } 609 }
609 610
610 } // namespace translate 611 } // namespace translate
OLDNEW
« no previous file with comments | « no previous file | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698