Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/values.h

Issue 2743363004: Temporarily CHECK use after free in Value (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 35f66df904b3f7bbde6f8d635405cb77bb82c9a3..d4b334c2a57d14ee7cc35e13b3919bc4e5072c63 100644
--- a/base/values.h
+++ b/base/values.h
@@ -173,6 +173,9 @@ class BASE_EXPORT Value {
// ListValue are properly inlined.
Type type_;
+ // TODO(crbug.com/697817): Remove after diagnosing the bug.
+ bool alive_ = true;
+
union {
bool bool_value_;
int int_value_;
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698