tools/perf/benchmarks/blink_perf.py - Issue 2743253011: Disable failing blink_perf.shadow_dom on N5X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2743253011: Disable failing blink_perf.shadow_dom on N5X (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/blink_perf.py

diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py

index 1c676846fa561aa87c53cae5a0a21cd2d45cbd2f..fc2b6f82fe36699ff6153893456c90f8d2870711 100644

--- a/tools/perf/benchmarks/blink_perf.py

+++ b/tools/perf/benchmarks/blink_perf.py

@@ -293,6 +293,10 @@ class BlinkPerfShadowDOM(_BlinkPerfBenchmark):

tag = 'shadow_dom'

subdir = 'ShadowDOM'

+ @classmethod

+ def ShouldDisable(cls, possible_browser): # http://crbug.com/702319

+ return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'

# This benchmark is for local testing, doesn't need to run on bots.

@benchmark.Disabled('all')

« no previous file with comments | « no previous file | no next file » | no next file with comments »