Split MirrorsData

pkg/compiler/lib/src/js_backend/impact_transformer.dart

Index: pkg/compiler/lib/src/js_backend/impact_transformer.dart
diff --git a/pkg/compiler/lib/src/js_backend/impact_transformer.dart b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
index 024a6c2086c9821787f431d660a3917e050fb8a0..cd8a039d32ed74f1f2a8849f4bb7d5c2a1ed71cb 100644
--- a/pkg/compiler/lib/src/js_backend/impact_transformer.dart
+++ b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
@@ -44,7 +44,7 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
   final NativeClassData _nativeClassData;
   final NativeResolutionEnqueuer _nativeResolutionEnqueuer;
   final BackendUsageBuilder _backendUsageBuider;
-  final MirrorsData _mirrorsData;
+  final MirrorsDataBuilder _mirrorsDataBuilder;
   final CustomElementsResolutionAnalysis _customElementsResolutionAnalysis;
   final RuntimeTypesNeedBuilder _rtiNeedBuilder;
 
@@ -57,7 +57,7 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
       this._nativeClassData,
       this._nativeResolutionEnqueuer,
       this._backendUsageBuider,
-      this._mirrorsData,
+      this._mirrorsDataBuilder,
       this._customElementsResolutionAnalysis,
       this._rtiNeedBuilder);
 
@@ -226,7 +226,7 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
     if (worldImpact.constSymbolNames.isNotEmpty) {
       registerImpact(_impacts.constSymbol);
       for (String constSymbolName in worldImpact.constSymbolNames) {
-        _mirrorsData.registerConstSymbol(constSymbolName);
+        _mirrorsDataBuilder.registerConstSymbol(constSymbolName);
       }
     }
 
@@ -343,7 +343,6 @@ class CodegenImpactTransformer {
   final RuntimeTypesNeed _rtiNeed;
   final NativeCodegenEnqueuer _nativeCodegenEnqueuer;
   final Namer _namer;
-  final MirrorsData _mirrorsData;
   final OneShotInterceptorData _oneShotInterceptorData;
   final LookupMapAnalysis _lookupMapAnalysis;
   final RuntimeTypesChecksBuilder _rtiChecksBuilder;
@@ -358,7 +357,6 @@ class CodegenImpactTransformer {
       this._rtiNeed,
       this._nativeCodegenEnqueuer,
       this._namer,
-      this._mirrorsData,
       this._oneShotInterceptorData,
       this._lookupMapAnalysis,
       this._rtiChecksBuilder);
@@ -442,10 +440,6 @@ class CodegenImpactTransformer {
       }
     }
 
-    for (String name in impact.constSymbols) {
-      _mirrorsData.registerConstSymbol(name);

[Siggi Cherem (dart-lang), 2017/03/14 05:52:14]

was this and registerUsedMember in the listener no longer needed? is it handled
by the impact processing now? Or did I missed this code moving somwhere else?

[Johnni Winther, 2017/03/15 12:52:42]

It's a subset of the registrations from resolution, anyway.

-    }
-
     for (Set<ClassElement> classes in impact.specializedGetInterceptors) {
       _oneShotInterceptorData.registerSpecializedGetInterceptor(
           classes, _namer);