Split MirrorsData

Split MirrorsData

- into MirrorsDataBuilder and MirrorsData both implemented by MirrorsDataImpl

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4321db0c8beb20307fa404df128d0c57666ec6d1

[Johnni Winther, 2017-03-13 15:51:17]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 05:52:14]

https://codereview.chromium.org/2743243003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/impact_transformer.dart (left):

https://codereview.chromium.org/2743243003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/impact_transformer.dart:446:
_mirrorsData.registerConstSymbol(name);
was this and registerUsedMember in the listener no longer needed? is it handled
by the impact processing now? Or did I missed this code moving somwhere else?

[Johnni Winther, 2017-03-15 12:52:42]

https://codereview.chromium.org/2743243003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/impact_transformer.dart (left):

https://codereview.chromium.org/2743243003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/impact_transformer.dart:446:
_mirrorsData.registerConstSymbol(name);
On 2017/03/14 05:52:14, Siggi Cherem (dart-lang) wrote:
> was this and registerUsedMember in the listener no longer needed? is it
handled
> by the impact processing now? Or did I missed this code moving somwhere else?

It's a subset of the registrations from resolution, anyway.

[Johnni Winther, 2017-03-15 21:32:59]

ping

[Siggi Cherem (dart-lang), 2017-03-15 21:33:30]

lgtm

[Johnni Winther, 2017-03-16 09:12:28]

Description was changed from

==========
Split MirrorsData

- into MirrorsDataBuilder and MirrorsData both implemented by MirrorsDataImpl
==========

to

==========
Split MirrorsData

- into MirrorsDataBuilder and MirrorsData both implemented by MirrorsDataImpl

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4321db0c8beb20307fa404df128d0c57666ec6d1
==========

[Johnni Winther, 2017-03-16 09:12:31]

Committed patchset #2 (id:20001) manually as
4321db0c8beb20307fa404df128d0c57666ec6d1 (presubmit successful).