Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 274313002: Remove --apps-new-install-bubble command line switch. (Closed)

Created:
6 years, 7 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove --apps-new-install-bubble command line switch. BUG=357776 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269734

Patch Set 1 #

Patch Set 2 : Remove a unnecessary header file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 3 chunks +1 line, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 7 months ago (2014-05-10 15:29:20 UTC) #1
asargent_no_longer_on_chrome
lgtm, thanks for the CL
6 years, 7 months ago (2014-05-11 23:58:14 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-12 00:00:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/274313002/20001
6 years, 7 months ago (2014-05-12 00:00:19 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 01:47:23 UTC) #5
Message was sent while issue was closed.
Change committed as 269734

Powered by Google App Engine
This is Rietveld 408576698